All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: panweiping3@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] vlan:remove duplicate <linux/if_vlan.h>
Date: Thu, 28 Jul 2011 01:38:30 -0700 (PDT)	[thread overview]
Message-ID: <20110728.013830.1949919665209265585.davem@davemloft.net> (raw)
In-Reply-To: <cover.1311841820.git.panweiping3@gmail.com>

From: Weiping Pan <panweiping3@gmail.com>
Date: Thu, 28 Jul 2011 16:37:38 +0800

> As net/8021q/vlan.h already includes <linux/if_vlan.h>,
> so other files that includes vlan.h need not to include it.

Please do not do this.

If someone wants to remove this implicit header dependency,
that someone will need to add all of the includes back.

It is better for people to include all the headers they need,
rather than rely upon such indirect inclusions.

I am not applying these patches.


  parent reply	other threads:[~2011-07-28  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28  8:37 [PATCH net-next 0/2] vlan:remove duplicate <linux/if_vlan.h> Weiping Pan
2011-07-28  8:37 ` [PATCH net-next 1/2] stp:add netdevice.h into stp.h Weiping Pan
2011-07-28  8:37 ` [PATCH net-next 2/2] vlan:remove duplicate <linux/if_vlan.h> Weiping Pan
2011-07-28  8:38 ` David Miller [this message]
2011-07-28  8:48   ` [PATCH net-next 0/2] " WeipingPan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110728.013830.1949919665209265585.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=panweiping3@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.