From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 28 Jul 2011 23:09:15 +0200
Subject: [U-Boot] [PATCH v7] unify version_string
In-Reply-To: <1311869959-6085-1-git-send-email-andreas.devel@googlemail.com>
References: <1311013444-74984-1-git-send-email-andreas.devel@googlemail.com>
	<1311869959-6085-1-git-send-email-andreas.devel@googlemail.com>
Message-ID: <20110728210915.D125515794DB@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Andreas,

In message <1311869959-6085-1-git-send-email-andreas.devel@googlemail.com> you wrote:
> 
> This patch removes the architecture specific implementation of
> version_string where possible. Some architectures use a special place
> and therefore we provide U_BOOT_VERSION_STRING definition and a common
> weak symbol version_string.
...
>  - proven to build with MAKEALL for at91rm9200ek and qong
>  - proven to run on at91rm9200ek device

Please note that it is NOT sufficient to build just two board, and
then even both of the same architecture!! Please re-read Note # 3 at
http://www.denx.de/wiki/U-Boot/Patches - it means you should build
_all_ board in at least two different architectures.

I believed you, twice.  You didn't, twice.  And you failed, twice.

Now we get tons of warnings like this:

cfb_console.c:1497: warning: format '%s' expects type 'char *', but argument 3 has type 'const char (*)[]'



Please fix!

[Note: your patch is in mainline, so we need an incremental fix.]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bankers do it with interest (penalty for early withdrawal).