From: "Michael S. Tsirkin" <mst@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Virtualization List <virtualization@lists.linux-foundation.org>
Subject: Re: [RFC PATCH 4/8] virtio: console: Ignore port name update request if name already set
Date: Fri, 29 Jul 2011 07:27:55 +0300 [thread overview]
Message-ID: <20110729042755.GF31888@redhat.com> (raw)
In-Reply-To: <20110729042619.GC24868@amit-x200.redhat.com>
On Fri, Jul 29, 2011 at 09:56:19AM +0530, Amit Shah wrote:
> On (Fri) 29 Jul 2011 [07:19:58], Michael S. Tsirkin wrote:
> > On Thu, Jul 28, 2011 at 08:05:09PM +0530, Amit Shah wrote:
> > > We don't allow port name changes dynamically for a port. So any
> > > requests by the host to change the name are ignored.
> >
> > It would be nice to check the name and if
> > changed, print a warning.
>
> But not change it, right?
That's what I meant.
> I don't know what applications expect, but
> I think we should keep the port names stable while they're plugged in.
>
> > > Before this patch, if the hypervisor sent a port name while we had one
> > > set already, we would leak memory equivalent to the size of the old
> > > name.
> > >
> > > This scenario wasn't expected so far, but with the suspend-resume
> > > support, we'll send the VIRTIO_CONSOLE_PORT_READY message after restore,
> > > which can get us into this situation.
> > >
> > > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> >
> > Memleaks are bad. So this is a bugfix we probably should have anyway?
>
> Yes.
>
> Amit
next prev parent reply other threads:[~2011-07-29 4:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 14:35 [RFC PATCH 0/8] virtio: Support for hibernation (S4) Amit Shah
2011-07-28 14:35 ` [RFC PATCH 1/8] virtio: pci: switch to new PM API Amit Shah
2011-07-28 14:35 ` [RFC PATCH 2/8] virtio-pci: add PM notification handlers for restore, freeze, thaw, poweroff Amit Shah
2011-07-28 14:35 ` [RFC PATCH 3/8] virtio-pci: save/restore config space across S4 Amit Shah
2011-07-29 4:07 ` Michael S. Tsirkin
2011-07-29 4:20 ` Amit Shah
2011-07-28 14:35 ` [RFC PATCH 4/8] virtio: console: Ignore port name update request if name already set Amit Shah
2011-07-29 4:19 ` Michael S. Tsirkin
2011-07-29 4:26 ` Amit Shah
2011-07-29 4:27 ` Michael S. Tsirkin [this message]
2011-07-28 14:35 ` [RFC PATCH 5/8] virtio: console: Use wait_event_freezable instead of _interruptible Amit Shah
2011-07-28 14:35 ` [RFC PATCH 6/8] virtio: console: Add freeze and restore handlers to support S4 Amit Shah
2011-07-28 14:35 ` [RFC PATCH 7/8] virtio: block: Add freeze, " Amit Shah
2011-07-28 14:35 ` [RFC PATCH 8/8] virtio: net: " Amit Shah
2011-07-29 4:13 ` Michael S. Tsirkin
2011-07-29 4:28 ` Amit Shah
2011-07-29 4:31 ` Michael S. Tsirkin
2011-07-29 5:08 ` Amit Shah
2011-08-10 10:53 ` [RFC PATCH 0/8] virtio: Support for hibernation (S4) Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729042755.GF31888@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.