From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756352Ab1G2LKF (ORCPT ); Fri, 29 Jul 2011 07:10:05 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:50864 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755453Ab1G2LKD (ORCPT ); Fri, 29 Jul 2011 07:10:03 -0400 Date: Fri, 29 Jul 2011 12:06:38 +0100 From: Russell King - ARM Linux To: Viresh Kumar Cc: linus.walleij@linaro.org, vinod.koul@intel.com, dan.j.williams@intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, armando.visconti@st.com, shiraz.hashim@st.com, vipin.kumar@st.com, rajeev-dlh.kumar@st.com, deepak.sikri@st.com, vipulkumar.samar@st.com, amit.virdi@st.com, pratyush.anand@st.com, bhupesh.sharma@st.com, viresh.linux@gmail.com Subject: Re: [PATCH 12/18] dmaengine/amba-pl08x: Add prep_single_byte_llis() routine Message-ID: <20110729110638.GH25640@n2100.arm.linux.org.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2011 at 04:19:22PM +0530, Viresh Kumar wrote: > Code for creating single byte llis is present at several places. Create a > routine to avoid code redundancy. > > Also, we don't need one lli per single byte transfer, we can have single lli to > do all single byte transfer. > > Signed-off-by: Viresh Kumar > --- > drivers/dma/amba-pl08x.c | 61 +++++++++++++++++++++++++--------------------- > 1 files changed, 33 insertions(+), 28 deletions(-) > > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c > index 3b7357e..590397d 100644 > --- a/drivers/dma/amba-pl08x.c > +++ b/drivers/dma/amba-pl08x.c > @@ -552,6 +552,14 @@ static void pl08x_fill_lli_for_desc(struct pl08x_lli_build_data *bd, > bd->remainder -= len; > } > > +static inline void prep_byte_width_lli(struct pl08x_lli_build_data *bd, > + u32 *cctl, u32 len, int num_llis, size_t *total_bytes) > +{ > + *cctl = pl08x_cctl_bits(*cctl, 1, 1, len); > + pl08x_fill_lli_for_desc(bd, num_llis, len, *cctl); > + (*total_bytes) += len; Seeing as your patch series started with a cleanup of spacing/tabbing, it's surprising to find a patch introducing new code which has broken tabbing. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Fri, 29 Jul 2011 12:06:38 +0100 Subject: [PATCH 12/18] dmaengine/amba-pl08x: Add prep_single_byte_llis() routine In-Reply-To: References: Message-ID: <20110729110638.GH25640@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 29, 2011 at 04:19:22PM +0530, Viresh Kumar wrote: > Code for creating single byte llis is present at several places. Create a > routine to avoid code redundancy. > > Also, we don't need one lli per single byte transfer, we can have single lli to > do all single byte transfer. > > Signed-off-by: Viresh Kumar > --- > drivers/dma/amba-pl08x.c | 61 +++++++++++++++++++++++++--------------------- > 1 files changed, 33 insertions(+), 28 deletions(-) > > diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c > index 3b7357e..590397d 100644 > --- a/drivers/dma/amba-pl08x.c > +++ b/drivers/dma/amba-pl08x.c > @@ -552,6 +552,14 @@ static void pl08x_fill_lli_for_desc(struct pl08x_lli_build_data *bd, > bd->remainder -= len; > } > > +static inline void prep_byte_width_lli(struct pl08x_lli_build_data *bd, > + u32 *cctl, u32 len, int num_llis, size_t *total_bytes) > +{ > + *cctl = pl08x_cctl_bits(*cctl, 1, 1, len); > + pl08x_fill_lli_for_desc(bd, num_llis, len, *cctl); > + (*total_bytes) += len; Seeing as your patch series started with a cleanup of spacing/tabbing, it's surprising to find a patch introducing new code which has broken tabbing.