From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297Ab1G2SVv (ORCPT ); Fri, 29 Jul 2011 14:21:51 -0400 Received: from oproxy4-pub.bluehost.com ([69.89.21.11]:38206 "HELO oproxy4-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751651Ab1G2SVt (ORCPT ); Fri, 29 Jul 2011 14:21:49 -0400 Date: Fri, 29 Jul 2011 11:21:46 -0700 From: Randy Dunlap To: Stephen Boyd Cc: sedat.dilek@gmail.com, Sedat Dilek , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Arnd Bergmann , Ingo Molnar , "H. Peter Anvin" , Chris Metcalf , Andrew Morton , Arjan van de Ven , Helge Deller , Heiko Carstens , akpm Subject: Re: linux-next: Tree for July 28 ("copy_from_user_overflow" undefined) Message-Id: <20110729112146.9459f48f.rdunlap@xenotime.net> In-Reply-To: <4E32F2ED.4020000@codeaurora.org> References: <20110728160136.771e2c0a.rdunlap@xenotime.net> <20110728220926.6d1a91f4.rdunlap@xenotime.net> <4E32F2ED.4020000@codeaurora.org> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jul 2011 10:50:37 -0700 Stephen Boyd wrote: > On 07/29/2011 02:45 AM, Sedat Dilek wrote: > > [ CCing all people from 0416 patch ] > > > > OK, here a quick review and looking for suspicious commits: > [snip] > > -- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -14,6 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \ > > proportions.o prio_heap.o ratelimit.o show_mem.o \ > > is_single_threaded.o plist.o decompress.o find_next_bit.o > > > > +lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o > > lib-$(CONFIG_MMU) += ioremap.o > > lib-$(CONFIG_SMP) += cpumask.o > > > > So, I can rebuild next-201107{27,28} with > > CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS=y and look again if the > > build-breakage in binfmt_misc is gone. > > > > Any comments from x86 folk? > > I already noticed this and sent a fixup patch to Andrew. Looks like he > never picked it up. The real fix is to change that lib-$(CONFIG... to > obj-$(CONFIG... > > See https://lkml.org/lkml/2011/7/6/6 for the patch. Thanks, that works. Adding Andrew to cc list. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: Tree for July 28 ("copy_from_user_overflow" undefined) Date: Fri, 29 Jul 2011 11:21:46 -0700 Message-ID: <20110729112146.9459f48f.rdunlap@xenotime.net> References: <20110728160136.771e2c0a.rdunlap@xenotime.net> <20110728220926.6d1a91f4.rdunlap@xenotime.net> <4E32F2ED.4020000@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy4-pub.bluehost.com ([69.89.21.11]:54546 "HELO oproxy4-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751765Ab1G2SVt (ORCPT ); Fri, 29 Jul 2011 14:21:49 -0400 In-Reply-To: <4E32F2ED.4020000@codeaurora.org> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Boyd Cc: sedat.dilek@gmail.com, Sedat Dilek , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Arnd Bergmann , Ingo Molnar , "H. Peter Anvin" , Chris Metcalf , Andrew Morton , Arjan van de Ven , Helge Deller , Heiko Carstens akpm On Fri, 29 Jul 2011 10:50:37 -0700 Stephen Boyd wrote: > On 07/29/2011 02:45 AM, Sedat Dilek wrote: > > [ CCing all people from 0416 patch ] > > > > OK, here a quick review and looking for suspicious commits: > [snip] > > -- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -14,6 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \ > > proportions.o prio_heap.o ratelimit.o show_mem.o \ > > is_single_threaded.o plist.o decompress.o find_next_bit.o > > > > +lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o > > lib-$(CONFIG_MMU) += ioremap.o > > lib-$(CONFIG_SMP) += cpumask.o > > > > So, I can rebuild next-201107{27,28} with > > CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS=y and look again if the > > build-breakage in binfmt_misc is gone. > > > > Any comments from x86 folk? > > I already noticed this and sent a fixup patch to Andrew. Looks like he > never picked it up. The real fix is to change that lib-$(CONFIG... to > obj-$(CONFIG... > > See https://lkml.org/lkml/2011/7/6/6 for the patch. Thanks, that works. Adding Andrew to cc list. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***