From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687Ab1G3TDN (ORCPT ); Sat, 30 Jul 2011 15:03:13 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:54525 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555Ab1G3TDJ (ORCPT ); Sat, 30 Jul 2011 15:03:09 -0400 Date: Sat, 30 Jul 2011 12:03:04 -0700 From: Dmitry Torokhov To: Stephen Rothwell Cc: Paul Gortmaker , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter , linux-input@vger.kernel.org Subject: Re: linux-next: build failure after merge of the moduleh tree Message-ID: <20110730190303.GC5686@core.coreip.homeip.net> References: <20110729151044.49f8bfdeeadb8edaf583f90d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110729151044.49f8bfdeeadb8edaf583f90d@canb.auug.org.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2011 at 03:10:44PM +1000, Stephen Rothwell wrote: > Hi Paul, > > After merging the moduleh tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/input/misc/kxtj9.c:644:1: warning: data definition has no type or storage class > drivers/input/misc/kxtj9.c:644:1: warning: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' > drivers/input/misc/kxtj9.c:644:1: warning: parameter names (without types) in function declaration > drivers/input/misc/kxtj9.c:649:12: error: 'THIS_MODULE' undeclared here (not in a function) > drivers/input/misc/kxtj9.c:669:20: error: expected declaration specifiers or '...' before string constant > drivers/input/misc/kxtj9.c:669:1: warning: data definition has no type or storage class > drivers/input/misc/kxtj9.c:669:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' > drivers/input/misc/kxtj9.c:669:20: warning: function declaration isn't a prototype > drivers/input/misc/kxtj9.c:670:15: error: expected declaration specifiers or '...' before string constant > drivers/input/misc/kxtj9.c:670:1: warning: data definition has no type or storage class > drivers/input/misc/kxtj9.c:670:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' > drivers/input/misc/kxtj9.c:670:15: warning: function declaration isn't a prototype > drivers/input/misc/kxtj9.c:671:16: error: expected declaration specifiers or '...' before string constant > drivers/input/misc/kxtj9.c:671:1: warning: data definition has no type or storage class > drivers/input/misc/kxtj9.c:671:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > drivers/input/misc/kxtj9.c:671:16: warning: function declaration isn't a prototype > drivers/input/misc/kxtj9.c: In function 'kxtj9_init': > drivers/input/misc/kxtj9.c:660:1: warning: control reaches end of non-void function > > I have added this patch for today: > > From: Stephen Rothwell > Date: Fri, 29 Jul 2011 15:06:46 +1000 > Subject: [PATCH] kxtj9: explictly include module.h > > since some of its facilities are used. > > Signed-off-by: Stephen Rothwell Applied, thanks Stephen. -- Dmitry