From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 01 Aug 2011 12:09:11 +0200
Subject: [U-Boot] [PATCH v4 2/2] ORIGEN: Add MMC SPL support
In-Reply-To: <CANuQgHGGaB3fWEFCXfgd97QxOfnizxLYvO8ke-v=5PzHyTN-Jg@mail.gmail.com>
References: <1311914519-10531-1-git-send-email-chander.kashyap@linaro.org>
	<1311914519-10531-3-git-send-email-chander.kashyap@linaro.org>
	<CALZhoSTV0zYX=ySw-vS6D51X0B_MHxt8sq1sTw7XEkyV1C=Odg@mail.gmail.com>
	<CANuQgHGGaB3fWEFCXfgd97QxOfnizxLYvO8ke-v=5PzHyTN-Jg@mail.gmail.com>
Message-ID: <20110801100911.0431D1673B92@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Chander Kashyap,

In message <CANuQgHGGaB3fWEFCXfgd97QxOfnizxLYvO8ke-v=5PzHyTN-Jg@mail.gmail.com> you wrote:
>
[200+ lines of unrelated quote deleted.]

> > > +void copy_uboot_to_ram(void)
> > > +{
> > > +       copy_sd_mmc_to_mem copy_bl2 = (copy_sd_mmc_to_mem)*(u32 *)(0x02020030);
> > > +       copy_bl2(BL2_START_OFFSET,\
> > > +               BL2_SIZE_BLOC_COUNT, (u32 *)CONFIG_SYS_TEXT_BASE);
> > > +}
> >
> > Curious to know, what the 0x02020030 hardcoding number means here?
> > It is a pointer to a API or hardware register, or anything else, how
> > this simple function perform the
> > data transfer from mmc to ram?
> >
> >  0x02020030 is iROM address, which contains pointer to API (copy from mmc
> from DDR) in iROM.

Well, as you can see yourself here, an external reviewer has no
chance to reand and understand this code. As mentioned before, this
needs serious rework.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Those who hate and fight must stop themselves -- otherwise it is  not
stopped.
	-- Spock, "Day of the Dove", stardate unknown