From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753329Ab1HAAan (ORCPT ); Sun, 31 Jul 2011 20:30:43 -0400 Received: from chilli.pcug.org.au ([203.10.76.44]:43076 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756Ab1HAAag (ORCPT ); Sun, 31 Jul 2011 20:30:36 -0400 Date: Mon, 1 Aug 2011 10:30:27 +1000 From: Stephen Rothwell To: Paul Gortmaker Cc: , , Jin Park , Randy Dunlap , Samuel Ortiz , Linus , Anton Vorontsov , Donggeun Kim Subject: Re: linux-next: build failure after merge of the moduleh tree Message-Id: <20110801103027.28dabe088d34567d74072dff@canb.auug.org.au> In-Reply-To: <20110731074454.GI31842@windriver.com> References: <20110729170659.91ad989caa407854c5e269a2@canb.auug.org.au> <20110731074454.GI31842@windriver.com> X-Mailer: Sylpheed 3.2.0beta1 (GTK+ 2.24.5; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Sun, 31 Jul 2011 03:44:55 -0400 Paul Gortmaker wrote: > > [linux-next: build failure after merge of the moduleh tree] On 29/07/2011 (Fri 17:06) Stephen Rothwell wrote: > > > After merging the moduleh tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/power/max8997_charger.c:205:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' This driver is upstream today. Randy wrote a patch for it (which I will apply to my fixes tree today): Date: Fri, 29 Jul 2011 21:11:43 -0700 From: Randy Dunlap Subject: [PATCH -next] power: max8998_charger.c needs module.h power/max8998_charger.c uses interfaces from linux/module.h, so it should include that file. This fixes build errors. Signed-off-by: Randy Dunlap --- drivers/power/max8998_charger.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20110729.orig/drivers/power/max8998_charger.c +++ linux-next-20110729/drivers/power/max8998_charger.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include > [...] > > drivers/regulator/aat2870-regulator.c:231:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > [...] > > The mmc ones I can fix; the power/regulator ones are not in master yet. > But since they need module.h, the fix can be applied by their respective > tree owner as well (vs. ones needing export.h -- which presents a minor > chicken-and-egg problem). OK, Randy wrote a fix patch for drivers/regulator/aat2870-regulator.c as well (which he cc'd to the wrong people :-(). I have it reproduced below and it should be applied to the mfd tree. I will apply it myself for today. Date: Fri, 29 Jul 2011 12:43:13 -0700 From: Randy Dunlap Subject: [PATCH -next] regulator: aat2870 needs module.h aat2870-regulator.c needs to include linux/module.h to fix multiple build errors. drivers/regulator/aat2870-regulator.c:145: error: 'THIS_MODULE' undeclared here (not in a function) drivers/regulator/aat2870-regulator.c:230: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/regulator/aat2870-regulator.c:231: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/regulator/aat2870-regulator.c:232: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' Signed-off-by: Randy Dunlap --- drivers/regulator/aat2870-regulator.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20110729.orig/drivers/regulator/aat2870-regulator.c +++ linux-next-20110729/drivers/regulator/aat2870-regulator.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: Re: linux-next: build failure after merge of the moduleh tree Date: Mon, 1 Aug 2011 10:30:27 +1000 Message-ID: <20110801103027.28dabe088d34567d74072dff@canb.auug.org.au> References: <20110729170659.91ad989caa407854c5e269a2@canb.auug.org.au> <20110731074454.GI31842@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from chilli.pcug.org.au ([203.10.76.44]:43076 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752756Ab1HAAag (ORCPT ); Sun, 31 Jul 2011 20:30:36 -0400 In-Reply-To: <20110731074454.GI31842@windriver.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Paul Gortmaker Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Jin Park , Randy Dunlap , Samuel Ortiz , Linus , Anton Vorontsov , Donggeun Kim Hi Paul, On Sun, 31 Jul 2011 03:44:55 -0400 Paul Gortmaker wrote: > > [linux-next: build failure after merge of the moduleh tree] On 29/07/2011 (Fri 17:06) Stephen Rothwell wrote: > > > After merging the moduleh tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/power/max8997_charger.c:205:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' This driver is upstream today. Randy wrote a patch for it (which I will apply to my fixes tree today): Date: Fri, 29 Jul 2011 21:11:43 -0700 From: Randy Dunlap Subject: [PATCH -next] power: max8998_charger.c needs module.h power/max8998_charger.c uses interfaces from linux/module.h, so it should include that file. This fixes build errors. Signed-off-by: Randy Dunlap --- drivers/power/max8998_charger.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20110729.orig/drivers/power/max8998_charger.c +++ linux-next-20110729/drivers/power/max8998_charger.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include > [...] > > drivers/regulator/aat2870-regulator.c:231:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' > [...] > > The mmc ones I can fix; the power/regulator ones are not in master yet. > But since they need module.h, the fix can be applied by their respective > tree owner as well (vs. ones needing export.h -- which presents a minor > chicken-and-egg problem). OK, Randy wrote a fix patch for drivers/regulator/aat2870-regulator.c as well (which he cc'd to the wrong people :-(). I have it reproduced below and it should be applied to the mfd tree. I will apply it myself for today. Date: Fri, 29 Jul 2011 12:43:13 -0700 From: Randy Dunlap Subject: [PATCH -next] regulator: aat2870 needs module.h aat2870-regulator.c needs to include linux/module.h to fix multiple build errors. drivers/regulator/aat2870-regulator.c:145: error: 'THIS_MODULE' undeclared here (not in a function) drivers/regulator/aat2870-regulator.c:230: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION' drivers/regulator/aat2870-regulator.c:231: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE' drivers/regulator/aat2870-regulator.c:232: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR' Signed-off-by: Randy Dunlap --- drivers/regulator/aat2870-regulator.c | 1 + 1 file changed, 1 insertion(+) --- linux-next-20110729.orig/drivers/regulator/aat2870-regulator.c +++ linux-next-20110729/drivers/regulator/aat2870-regulator.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/