From: Andi Kleen <andi@firstfloor.org>
To: David Rientjes <rientjes@google.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: Revert needed: udev spewing warnons on common systems in 3.0
Date: Wed, 3 Aug 2011 00:06:19 +0200 [thread overview]
Message-ID: <20110802220619.GI27083@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1108021439030.12258@chino.kir.corp.google.com>
> All of the examples that I've cited that were fixed as a result of the
> printk_once() were through bugzilla for the developers of those
> applications, I didn't talk to any distro when I publically said I would
> handle all reports of this warning that people didn't know how to triage.
The distros would have updated udev at some point anyways.
But they won't do it for old releases.
But the users who don't want to update will just be annoyed
(in Linus words) the backtrace forever.
The big problem I have with your "use kernel WARN_ONs to social engineer"
approach is that the devalues a good mechanism to report kernel
problems.
Traditionally at least I looked at all backtraces
and tried to get at the bottom of the problem to improve the kernel.
I know from email that users reported those too.
Now that all my test systems spew them on every boot I cannot do
that anymore. When I see a backtrace scrolling by I now just
think "Ah it's probably David Rientjes trying to social engineer
someone again".
And then some point noone will look at backtraces anymore because
they have become normal. Really serious problems will get missed.
And this is a bad thing.
IMHO still the only sensible thing that can be done with this patch
is to revert it.
-Andi
next prev parent reply other threads:[~2011-08-02 22:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 0:52 Revert needed: udev spewing warnons on common systems in 3.0 Andi Kleen
2011-08-02 1:32 ` Andrew Morton
2011-08-02 1:41 ` Linus Torvalds
2011-08-02 2:22 ` David Rientjes
2011-08-02 9:16 ` Alan Cox
2011-08-02 9:53 ` David Rientjes
2011-08-02 10:11 ` Alan Cox
2011-08-02 11:22 ` David Miller
2011-08-02 14:45 ` Andi Kleen
2011-08-02 21:50 ` David Rientjes
2011-08-02 21:45 ` David Rientjes
2011-08-02 22:06 ` Andi Kleen [this message]
2011-08-02 11:20 ` David Miller
2011-08-02 2:34 ` David Rientjes
2011-08-02 6:07 ` Andi Kleen
2011-08-02 9:54 ` [patch] oom: change warning for deprecated oom_adj to avoid WARN_ONCE() David Rientjes
2011-08-03 6:10 ` Borislav Petkov
2011-08-04 6:04 ` David Rientjes
2011-08-04 7:48 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110802220619.GI27083@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.