All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Avi Kivity <avi@redhat.com>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	kvm@vger.kernel.org
Subject: Re: [PATCH -next] kvm: uses TASKSTATS, depends on NET
Date: Wed, 3 Aug 2011 18:02:19 -0300	[thread overview]
Message-ID: <20110803210218.GC31923@amt.cnet> (raw)
In-Reply-To: <20110802125431.e1902bd1.rdunlap@xenotime.net>

On Tue, Aug 02, 2011 at 12:54:31PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> CONFIG_TASKSTATS just had a change to use netlink, including
> a change to "depends on NET".  Since "select" does not follow
> dependencies, KVM also needs to depend on NET to prevent build
> errors when CONFIG_NET is not enabled.
> 
> Sample of the reported "undefined reference" build errors:
> 
> taskstats.c:(.text+0x8f686): undefined reference to `nla_put'
> taskstats.c:(.text+0x8f721): undefined reference to `nla_reserve'
> taskstats.c:(.text+0x8f8fb): undefined reference to `init_net'
> taskstats.c:(.text+0x8f905): undefined reference to `netlink_unicast'
> taskstats.c:(.text+0x8f934): undefined reference to `kfree_skb'
> taskstats.c:(.text+0x8f9e9): undefined reference to `skb_clone'
> taskstats.c:(.text+0x90060): undefined reference to `__alloc_skb'
> taskstats.c:(.text+0x901e9): undefined reference to `skb_put'
> taskstats.c:(.init.text+0x4665): undefined reference to `genl_register_family'
> taskstats.c:(.init.text+0x4699): undefined reference to `genl_register_ops'
> taskstats.c:(.init.text+0x4710): undefined reference to `genl_unregister_ops'
> taskstats.c:(.init.text+0x471c): undefined reference to `genl_unregister_family'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>

Applied, thanks.


      reply	other threads:[~2011-08-03 21:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02  5:57 linux-next: Tree for Aug 2 Stephen Rothwell
2011-08-02 19:54 ` [PATCH -next] kvm: uses TASKSTATS, depends on NET Randy Dunlap
2011-08-03 21:02   ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110803210218.GC31923@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.