From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/4] Don't compile in large memory test function by default.
Date: Thu, 04 Aug 2011 12:14:37 +0200 [thread overview]
Message-ID: <20110804101437.D3E6921C695@gemini.denx.de> (raw)
In-Reply-To: <4E3A3CB8.2030703@aribaud.net>
Dear Albert ARIBAUD,
In message <4E3A3CB8.2030703@aribaud.net> you wrote:
>
> > I didn't receive comments on this one. By not compiling this by
> > default it removes a couple of #defines people need to think
> > about. Also, I'm guessing the memory test isn't used very much, so
> > this makes u-boot a bit smaller.
...
> > common/cmd_mem.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
...
> Applied to u-boot-arm/master, thanks!
Argh..
This is NOT an ARM specific patch.
Even worse, it changes global behaviour for most baords. This cannot
be dones easily.
Sorry, but NAK.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is wanted is not the will to believe, but the will to find out,
which is the exact opposite.
-- Bertrand Russell, "Skeptical Essays", 1928
next prev parent reply other threads:[~2011-08-04 10:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 14:21 [U-Boot] [PATCH V2 0/4] make u-boot a bit easier for newcomers to port Christopher Harvey
2011-07-07 14:26 ` [U-Boot] [PATCH V2 1/4] Added documentation for CONFIG_SYS_TEXT_BASE Christopher Harvey
2011-08-04 6:20 ` Albert ARIBAUD
2011-08-24 18:34 ` Christopher Harvey
2011-08-24 19:12 ` Wolfgang Denk
2011-07-07 14:31 ` [U-Boot] [PATCH V2 2/4] Don't compile in large memory test function by default Christopher Harvey
2011-08-04 6:31 ` Albert ARIBAUD
2011-08-04 10:14 ` Wolfgang Denk [this message]
2011-08-04 10:54 ` Albert ARIBAUD
2011-08-04 10:20 ` Wolfgang Denk
2011-07-07 14:34 ` [U-Boot] [PATCH V2 3/4] ARM: Warn when the machine ID isn't set Christopher Harvey
2011-07-07 16:55 ` Igor Grinberg
2011-07-07 21:02 ` Igor Grinberg
2011-07-14 18:02 ` [U-Boot] [PATCH V3 " Christopher Harvey
2011-07-14 19:02 ` Igor Grinberg
2011-07-15 12:44 ` Stefano Babic
2011-07-17 6:53 ` Igor Grinberg
2011-07-17 8:26 ` stefano babic
2011-07-17 9:00 ` Albert ARIBAUD
2011-07-18 17:33 ` [U-Boot] [PATCH V4 " Christopher Harvey
2011-08-04 6:30 ` Albert ARIBAUD
2011-08-24 14:31 ` Albert ARIBAUD
2011-08-24 17:37 ` Christopher Harvey
2011-08-30 20:49 ` [U-Boot] [PATCH V5 " Christopher Harvey
2011-07-07 14:37 ` [U-Boot] [PATCH V2 4/4] Removed unused define, CONFIG_ARMV7 Christopher Harvey
2011-08-04 6:33 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804101437.D3E6921C695@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.