From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp1aN-0008MR-87 for qemu-devel@nongnu.org; Thu, 04 Aug 2011 13:19:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qp1aL-0002Qn-DV for qemu-devel@nongnu.org; Thu, 04 Aug 2011 13:19:55 -0400 Received: from mail.univention.de ([82.198.197.8]:2518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp1aL-0002QA-6l for qemu-devel@nongnu.org; Thu, 04 Aug 2011 13:19:53 -0400 From: Philipp Hahn Date: Thu, 4 Aug 2011 19:19:39 +0200 References: <1312474673-2705-1-git-send-email-kwolf@redhat.com> <1312475099-3323-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1312475099-3323-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1682413.Rh7sv3zL1h"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201108041919.44006.hahn@univention.de> Subject: Re: [Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , stefanha@gmail.com --nextPart1682413.Rh7sv3zL1h Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello, On Thursday 04 August 2011 18:24:59 Kevin Wolf wrote: > When loading an internal snapshot whose L1 table is smaller than the > current L1 table, the size of the current L1 would be shrunk to the > snapshot's L1 size in memory, but not on disk. This lead to incorrect > refcount updates and eventuelly to image corruption. > > Instead of writing the new L1 size to disk, this simply retains the bigger > L1 size that is currently in use and makes sure that the unused part is > zeroed. > > Signed-off-by: Kevin Wolf Tested-by: Philipp Hahn > Philipp, I think this should fix your corruption. Please give it a try. Yes, the patch looks conceptually right and fixes the observed problem. > Anthony, this must go into 0.15. That bug is also found in 0.12.4 and 0.14.1, so if there ever shoudl be an= =20 update to those branches, that fix should be applied there as well. Thanks for your fast support. Sincerely Philipp Hahn =2D-=20 Philipp Hahn Open Source Software Engineer hahn@univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ --nextPart1682413.Rh7sv3zL1h Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEABECAAYFAk461KsACgkQYPlgoZpUDjm2ogCdEtm8Ij+6QjaoMHVv1LRzLCfm h10AoLAjiinT3jXMWmjKNJnrYsRA26by =/KkD -----END PGP SIGNATURE----- --nextPart1682413.Rh7sv3zL1h--