From: David Miller <davem@davemloft.net>
To: dannguo@cisco.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH] enic: Add timestamp to network interface stats
Date: Fri, 05 Aug 2011 23:25:35 -0700 (PDT) [thread overview]
Message-ID: <20110805.232535.445092900994011542.davem@davemloft.net> (raw)
In-Reply-To: <20110805001124.32402.42919.stgit@savbu-pc100.cisco.com>
From: Danny Guo <dannguo@cisco.com>
Date: Thu, 04 Aug 2011 17:11:24 -0700
> From: Danny Guo <dannguo@cisco.com>
>
> This patch adds timestamps in ethtool stats. It makes it easier to provide scripts to users to calculate throughput, etc. It also allows software to synchronize timestamps with host time for correlating host events with stats collection.
>
> Signed-off-by: Danny Guo <dannguo@cisco.com>
> Signed-off-by: Vasanthy Kolluri <vkolluri@cisco.com>
> Signed-off-by: Roopa Prabhu <roprabhu@cisco.com>
> Signed-off-by: David Wang <dwang2@cisco.com>
It's "easier" but only for your specific driver if we let this patch
go in.
Everyone tends to come up with the "easy" but localized and selfish
solution.
We have not one but several rate estimators in the kernel, if that's
unusable then fix them instead of just going for private facilities
that only will work with your driver.
I'm not applying this, sorry.
prev parent reply other threads:[~2011-08-06 6:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 0:11 [net-next-2.6 PATCH] enic: Add timestamp to network interface stats Danny Guo
2011-08-05 4:42 ` Stephen Hemminger
2011-08-06 6:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805.232535.445092900994011542.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dannguo@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.