From: Dave Jones <davej@redhat.com>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
tom.l.nguyen@intel.com, yanmin.zhang@intel.com
Subject: Re: [rfc] suppress excessive AER output
Date: Thu, 4 Aug 2011 22:33:09 -0400 [thread overview]
Message-ID: <20110805023309.GA20447@redhat.com> (raw)
In-Reply-To: <CACqU3MXaHJ+AnUpkeBWg=aHp3iJBR=uXgr22pinAdu-wgeoCuQ@mail.gmail.com>
On Thu, Aug 04, 2011 at 10:24:07PM -0400, Arnaud Lacombe wrote:
> Hi,
>
> On Wed, Aug 3, 2011 at 6:34 PM, Dave Jones <davej@redhat.com> wrote:
> > I have a machine that has developed some kind of problem with
> > its onboard ethernet. It still boots, but spewed almost 1.5G of text
> > (2381585 instances of the warning below) before we realised what
> > was going on, and blacklisted the igb driver.
> >
> > Is it worth logging every single error when we're flooding like this ?
> > It seems unlikely that we'll find useful information in amongst that much data
> > that wasn't already in the first 100 instances.
> >
> > I picked 100 in the (untested) example patch below arbitarily, but the exact
> > value could be smaller, or slightly bigger..
> >
> > could we do something like this maybe ?
> >
> Please do not reinvent the wheel and use printk_ratelimited().
It's a different wheel.
printk_ratelimit slows down the output, but would still cause a lot of messages.
my diff turns it off completely after a threshold (apart from at the ulong wrap,
which I overlooked).
Dave
prev parent reply other threads:[~2011-08-05 2:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 22:34 [rfc] suppress excessive AER output Dave Jones
2011-08-04 5:54 ` Zhang, Yanmin
2011-08-05 1:50 ` Dave Jones
2011-08-05 1:59 ` Zhang, Yanmin
2011-08-05 2:09 ` Dave Jones
2011-08-04 6:45 ` huang ying
2011-08-05 1:50 ` Dave Jones
2011-08-05 2:24 ` Arnaud Lacombe
2011-08-05 2:33 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805023309.GA20447@redhat.com \
--to=davej@redhat.com \
--cc=lacombar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.