All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Wouter Verhelst <w@uter.be>
Cc: paul.clements@steeleye.com, linux-kernel@vger.kernel.org
Subject: Re: [Nbd] [PATCH v2] nbd: nbd sysfs framework
Date: Thu, 4 Aug 2011 21:27:30 -0700	[thread overview]
Message-ID: <20110805042730.GA25389@kroah.com> (raw)
In-Reply-To: <20110805014752.GJ4109@grep.be>

On Fri, Aug 05, 2011 at 03:47:52AM +0200, Wouter Verhelst wrote:
> On Thu, Aug 04, 2011 at 06:11:27PM -0400, paul.clements@steeleye.com wrote:
> > diff --git a/Documentation/ABI/testing/sysfs-block-nbd b/Documentation/ABI/testing/sysfs-block-nbd
> > new file mode 100644
> > index 0000000..3728d9f
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-block-nbd
> > @@ -0,0 +1,8 @@
> > +What:		/sys/block/nbd<id>/nbd/pid
> > +Date:		August 2011
> > +Contact:	Paul Clements <paul.clements@steeleye.com>
> > +Description:
> > +		The pid file is read-only and specifies the pid of the
> > +		caller of NBD_DO_IT ioctl (normally this is the nbd-client).
> > +		The pid will be zero if the nbd connection is not
> > +		currently established.
> 
> That's different from current behaviour: in the current implementation,
> the absense of a connection is signalled by the absense of the PID file,
> rather than the contents being zero. Dunno whether that change is
> intentional, but I thought I'd check before changing nbd-client code...

The current behavior should not change, so that would be a bug and yet
another reason to reject this patch :)

      parent reply	other threads:[~2011-08-05  4:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 22:11 [PATCH v2] nbd: nbd sysfs framework paul.clements
2011-08-04 23:18 ` Greg KH
     [not found] ` <20110805014752.GJ4109@grep.be>
2011-08-05  4:27   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110805042730.GA25389@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.clements@steeleye.com \
    --cc=w@uter.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.