From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH 6/6] OMAP: McBSP: use existing macros for converting between devices Date: Fri, 5 Aug 2011 09:02:44 +0300 Message-ID: <20110805090244.f6e5f65a6829138d929bd4a9@gmail.com> References: <1312472710-31758-1-git-send-email-khilman@ti.com> <1312472710-31758-7-git-send-email-khilman@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:62146 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756335Ab1HEGCq (ORCPT ); Fri, 5 Aug 2011 02:02:46 -0400 Received: by fxh19 with SMTP id 19so2467737fxh.19 for ; Thu, 04 Aug 2011 23:02:45 -0700 (PDT) In-Reply-To: <1312472710-31758-7-git-send-email-khilman@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi Kevin On Thu, 4 Aug 2011 08:45:10 -0700 Kevin Hilman wrote: > For converting from struct device to platform_device, and from > platform_device to struct omap_device, there are existing macros. Use > them instead of manual use of container_of(). > > Signed-off-by: Kevin Hilman > --- > arch/arm/plat-omap/mcbsp.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c > index 3c1fbdc..47016f7 100644 > --- a/arch/arm/plat-omap/mcbsp.c > +++ b/arch/arm/plat-omap/mcbsp.c > @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); > #ifdef CONFIG_ARCH_OMAP3 > static struct omap_device *find_omap_device_by_dev(struct device *dev) > { > - struct platform_device *pdev = container_of(dev, > - struct platform_device, dev); > - return container_of(pdev, struct omap_device, pdev); > + struct platform_device *pdev = to_platform_device(dev); > + > + return to_omap_device(pdev); > } > I have a better alternative (that removes these unused lines) here: http://marc.info/?l=linux-omap&m=130951039226392&w=2 I'm fine if you need to take my patch if there's urgent need to modify these lines or otherwise I can carry it when sending an updated version of my earlier McBSP cleanup set. -- Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: jhnikula@gmail.com (Jarkko Nikula) Date: Fri, 5 Aug 2011 09:02:44 +0300 Subject: [PATCH 6/6] OMAP: McBSP: use existing macros for converting between devices In-Reply-To: <1312472710-31758-7-git-send-email-khilman@ti.com> References: <1312472710-31758-1-git-send-email-khilman@ti.com> <1312472710-31758-7-git-send-email-khilman@ti.com> Message-ID: <20110805090244.f6e5f65a6829138d929bd4a9@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kevin On Thu, 4 Aug 2011 08:45:10 -0700 Kevin Hilman wrote: > For converting from struct device to platform_device, and from > platform_device to struct omap_device, there are existing macros. Use > them instead of manual use of container_of(). > > Signed-off-by: Kevin Hilman > --- > arch/arm/plat-omap/mcbsp.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c > index 3c1fbdc..47016f7 100644 > --- a/arch/arm/plat-omap/mcbsp.c > +++ b/arch/arm/plat-omap/mcbsp.c > @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); > #ifdef CONFIG_ARCH_OMAP3 > static struct omap_device *find_omap_device_by_dev(struct device *dev) > { > - struct platform_device *pdev = container_of(dev, > - struct platform_device, dev); > - return container_of(pdev, struct omap_device, pdev); > + struct platform_device *pdev = to_platform_device(dev); > + > + return to_omap_device(pdev); > } > I have a better alternative (that removes these unused lines) here: http://marc.info/?l=linux-omap&m=130951039226392&w=2 I'm fine if you need to take my patch if there's urgent need to modify these lines or otherwise I can carry it when sending an updated version of my earlier McBSP cleanup set. -- Jarkko