From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: selinux@gmail.com, davej@redhat.com, netdev@vger.kernel.org
Subject: Re: return of ip_rt_bug()
Date: Sun, 07 Aug 2011 22:20:42 -0700 (PDT) [thread overview]
Message-ID: <20110807.222042.1034530719366562334.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1108070104440.1413@ja.ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Sun, 7 Aug 2011 01:14:22 +0300 (EEST)
> The problem: if we have input route in the cache
> it can be returned to callers that request output route.
> That is why dst_output points to ip_rt_bug.
Good spotting Julian.
This is my fault entirely. First I removed the thing we now call
->rt_route_iif which led to bug fix:
commit 1b86a58f9d7ce4fe2377687f378fbfb53bdc9b6c
Author: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date: Thu Apr 7 14:04:08 2011 -0700
ipv4: Fix "Set rt->rt_iif more sanely on output routes."
but I forgot to make sure we also added back the key comparison
on lookups as well :-/
Applied and queued up for -stable, thanks!
next prev parent reply other threads:[~2011-08-08 5:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 17:09 return of ip_rt_bug() Dave Jones
2011-08-04 7:23 ` David Miller
2011-08-04 12:20 ` Julian Anastasov
2011-08-04 13:14 ` Tom London
2011-08-04 17:37 ` Julian Anastasov
2011-08-04 17:48 ` Tom London
2011-08-05 2:45 ` Tom London
2011-08-05 7:56 ` Julian Anastasov
2011-08-05 13:18 ` Tom London
2011-08-05 13:30 ` Tom London
2011-08-05 13:37 ` Tom London
2011-08-06 22:14 ` Julian Anastasov
2011-08-08 5:20 ` David Miller [this message]
2011-08-09 13:51 ` Julian Anastasov
2011-08-11 13:00 ` David Miller
2011-08-11 16:36 ` rt_iif conversions (was Re: return of ip_rt_bug()) Julian Anastasov
2011-08-12 1:01 ` rt_iif conversions David Miller
2011-08-05 16:36 ` return of ip_rt_bug() Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110807.222042.1034530719366562334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=selinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.