From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753593Ab1HIUa0 (ORCPT ); Tue, 9 Aug 2011 16:30:26 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:58237 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528Ab1HIUaY (ORCPT ); Tue, 9 Aug 2011 16:30:24 -0400 From: "Rafael J. Wysocki" To: Martin Schwidefsky Subject: Re: [patch 1/1] [PATCH] include storage keys in hibernation image. Date: Tue, 9 Aug 2011 21:56:12 +0200 User-Agent: KMail/1.13.6 (Linux/3.1.0-rc1+; KDE/4.6.0; x86_64; ; ) Cc: linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Pavel Machek , Jiri Slaby References: <20110608074523.211912903@de.ibm.com> <201107290001.14465.rjw@sisk.pl> <20110809174524.45cd496d@mschwide> In-Reply-To: <20110809174524.45cd496d@mschwide> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201108092156.12451.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, August 09, 2011, Martin Schwidefsky wrote: > On Fri, 29 Jul 2011 00:01:14 +0200 > "Rafael J. Wysocki" wrote: > > > Sorry for the extreme delay. > > No big deal, I have been busy with other things anyway. > > > Having reconsidered things I think the code under the #ifdef above > > should really go to arch/s390. > > Ok, that is reasonable. > > > Now, for the purpose of exporting the headers I'd introduce > > CONFIG_ARCH_SAVE_PAGE_KEYS and make S390 do > > > > select ARCH_SAVE_PAGE_KEYS if HIBERNATION > > > > and I'd put a #ifdef depending on that into include/linux/suspend.h. > > > > Apart from this, I have only one complaint, which is that the kerneldoc > > comments should follow the standard (the other comments in snapshot.c don't, > > but that's a matter for a separate patch). > > Sounds good. I will come up with new patches for this and resend them > for review. Might be one or two weeks though, currently conferencing in > Orlando.. OK, thanks!