All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kuninori.morimoto.gx@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: sh_irda: fixup build error on v3.1
Date: Wed, 10 Aug 2011 23:15:58 -0700 (PDT)	[thread overview]
Message-ID: <20110810.231558.2202030270747790994.davem@davemloft.net> (raw)
In-Reply-To: <87aabgwl9y.wl%kuninori.morimoto.gx@renesas.com>

From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Date: Wed, 10 Aug 2011 22:49:01 -0700 (PDT)

> @@ -171,7 +173,7 @@ static void sh_irda_write(struct sh_irda_self *self, u32 offset, u16 data)
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&self->lock, flags);
> -	iowrite16(data, self->membase + offset);
> +	__raw_writew(data, self->membase + offset);
>  	spin_unlock_irqrestore(&self->lock, flags);

Every platform, including "sh", provides ioread16() and iowrite16().

So changing this is not part of "fixup build error" as your commit
message states.

If this change is needed, it should be in a seperate commit and with
a proper explanation in the commit message.

       reply	other threads:[~2011-08-11  6:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87aabgwl9y.wl%kuninori.morimoto.gx@renesas.com>
2011-08-11  6:15 ` David Miller [this message]
2011-08-11  9:02   ` [PATCH] net: sh_irda: fixup build error on v3.1 Kuninori Morimoto
2011-08-11  9:19   ` [PATCH v2] " Kuninori Morimoto
2011-08-11  9:25     ` [PATCH 1/3 v2] net/irda: sh_irda: add missing header kuninori.morimoto.gx
2011-08-11 12:53       ` David Miller
2011-08-11  9:26     ` [PATCH 2/3 v2] net/irda: sh_sir: " kuninori.morimoto.gx
2011-08-11 12:53       ` David Miller
2011-08-11  9:26     ` [PATCH 3/3] net/irda: sh_sir: tidyup compile warning kuninori.morimoto.gx
2011-08-11 12:54       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810.231558.2202030270747790994.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.