From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238Ab1HJDXF (ORCPT ); Tue, 9 Aug 2011 23:23:05 -0400 Received: from mga03.intel.com ([143.182.124.21]:22210 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441Ab1HJDXE (ORCPT ); Tue, 9 Aug 2011 23:23:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,348,1309762800"; d="scan'208";a="36901840" Date: Wed, 10 Aug 2011 11:22:49 +0800 From: Wu Fengguang To: Peter Zijlstra Cc: Vivek Goyal , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Andrea Righi , linux-mm , LKML Subject: Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages() Message-ID: <20110810032249.GA24486@localhost> References: <20110806084447.388624428@intel.com> <20110806094527.136636891@intel.com> <20110809181543.GG6482@redhat.com> <1312915266.1083.75.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1312915266.1083.75.camel@twins> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2011 at 02:41:05AM +0800, Peter Zijlstra wrote: > On Tue, 2011-08-09 at 14:15 -0400, Vivek Goyal wrote: > > > > So far bw had pos_ratio as value now it will be replaced with actual > > bandwidth as value. It makes code confusing. So using pos_ratio will > > help. > > Agreed on consistency, also I'm not sure bandwidth is the right term > here to begin with, its a pages/s unit and I think rate would be better > here. But whatever ;-) Good idea, I'll switch to the name "rate". Thanks, Fengguang From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 5/5] writeback: IO-less balance_dirty_pages() Date: Wed, 10 Aug 2011 11:22:49 +0800 Message-ID: <20110810032249.GA24486@localhost> References: <20110806084447.388624428@intel.com> <20110806094527.136636891@intel.com> <20110809181543.GG6482@redhat.com> <1312915266.1083.75.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vivek Goyal , "linux-fsdevel@vger.kernel.org" , Andrew Morton , Jan Kara , Christoph Hellwig , Dave Chinner , Greg Thelen , Minchan Kim , Andrea Righi , linux-mm , LKML To: Peter Zijlstra Return-path: Content-Disposition: inline In-Reply-To: <1312915266.1083.75.camel@twins> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Aug 10, 2011 at 02:41:05AM +0800, Peter Zijlstra wrote: > On Tue, 2011-08-09 at 14:15 -0400, Vivek Goyal wrote: > > > > So far bw had pos_ratio as value now it will be replaced with actual > > bandwidth as value. It makes code confusing. So using pos_ratio will > > help. > > Agreed on consistency, also I'm not sure bandwidth is the right term > here to begin with, its a pages/s unit and I think rate would be better > here. But whatever ;-) Good idea, I'll switch to the name "rate". Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org