All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@suse.de (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] Move top level platform devices in sysfs to /sys/devices/soc/X
Date: Thu, 11 Aug 2011 08:22:39 -0700	[thread overview]
Message-ID: <20110811152239.GB13745@suse.de> (raw)
In-Reply-To: <4E43C399.1040505@stericsson.com>

On Thu, Aug 11, 2011 at 01:57:13PM +0200, Linus Walleij wrote:
> On 08/10/2011 05:02 PM, Greg KH wrote:
> >On Wed, Aug 10, 2011 at 02:03:42PM +0100, Lee Jones wrote:
> >>At the request of Arnd Bergmann this patch moves all SoC
> >>platform devices found in sysfs from /sys/devices/platform to
> >>/sys/devices/soc/<SoCNum>/. It is believed as the devices are
> >>SoC specific and a /sys/devices/soc node has recently become
> >>available, that this would be a more appropriate place to
> >>display the data.
> >And what userspace tools did you just break by doing this?
> 
> I think most of our userspace for this platform poking
> around in sysfs use /sys/class/* so should be pretty OK.
> 
> And none of which were properly documented in
> Documentation/ABI/* anyway, so do we care?
> grep -r 'devices/platform' Documentation/ABI/
> doesn't show anything relating to the ux500.
> 
> The major breakage would be out-of-tree stuff, if
> any.
> 
> Which is out-of-tree due to the absence of a SoC ID
> framework.
> 
> Which was nixed by Arnd et al precisely because
> the above change was not part of it.
> 
> It's a bit hard for Lee to please everyone with this
> one I suspect :-D

Ok, if you get guarantees from anyone using the in-kernel platform soc
code that this move is acceptable, and you guarantee that no userspace
tools will break, that's fine.  But odds are, you are going to break
something...

greg k-h

  reply	other threads:[~2011-08-11 15:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 13:03 [PATCH 1/4] Framework for exporting System-on-Chip information via sysfs Lee Jones
2011-08-10 13:03 ` [PATCH 2/4] Add documenation for new sysfs devices/soc functionallity Lee Jones
2011-08-10 15:02   ` Greg KH
2011-08-10 13:03 ` [PATCH 3/4] mach-ux500: export System-on-Chip information ux500 via sysfs Lee Jones
2011-08-10 13:34   ` Jamie Iles
2011-08-10 15:03   ` Greg KH
2011-09-01  6:58     ` Lee Jones
2011-09-01 14:24       ` Greg KH
2011-08-24 16:10   ` Arnd Bergmann
2011-08-25  9:20     ` Lee Jones
2011-08-25 14:56       ` Arnd Bergmann
2011-08-25 15:16         ` Lee Jones
2011-08-10 13:03 ` [PATCH 4/4] Move top level platform devices in sysfs to /sys/devices/soc/X Lee Jones
2011-08-10 15:02   ` Greg KH
2011-08-11 11:57     ` Linus Walleij
2011-08-11 15:22       ` Greg KH [this message]
2011-08-11 18:24         ` Linus Walleij
2011-08-24 15:21           ` Arnd Bergmann
2011-08-24 15:25   ` Arnd Bergmann
2011-08-10 13:29 ` [PATCH 1/4] Framework for exporting System-on-Chip information via sysfs Jamie Iles
2011-08-24 14:08   ` Lee Jones
2011-08-24 14:19     ` Jamie Iles
2011-08-24 14:22       ` Jamie Iles
2011-08-10 15:02 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110811152239.GB13745@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.