From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Rees Subject: Re: [PATCH] pnfs: Automatically select blocks & objects layouts Date: Thu, 11 Aug 2011 18:13:05 -0400 Message-ID: <20110811221305.GA8608@merit.edu> References: <20110810122304.96b8be67.rdunlap@xenotime.net> <20110810175829.a834d80f.rdunlap@xenotime.net> <4E43AAD1.7090806@tonian.com> <4E4422FD.3060706@panasas.com> <4E444552.9030105@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4E444552.9030105-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Boaz Harrosh Cc: Benny Halevy , Sorin Faibish , peter honeyman , tao.peng-mb1K0bWo544@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, rdunlap-/UHa2rfvQTnk1uMJSBkQmQ@public.gmane.org, bergwolf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Welch, Brent" List-Id: linux-raid.ids Boaz Harrosh wrote: What about the below? based on v3.1-rc1 ---- From: Boaz Harrosh Subject: [PATCH] pnfs: Automatically select blocks & objects layouts Just like files-layout, blocks & objects layouts are part of the NFS 4.1 protocol and should be automatically selected if NFS_4_1 is selected. The small problem is that these depend on other Kernel support being present, while files only depends on NFS itself. This patch removes from the user choice the presence of objects and blocks layout. But makes sure these are selected only if the depended subsystems are present in the Kernel. Signed-off-by: Boaz Harrosh Acked-by: Jim Rees I think this is what we want. There is no point allowing the user to pick and choose various layout drivers. If they have selected nfs4.1 they should get all the layout drivers their kernel will support, based on the dependencies. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638Ab1HKWT2 (ORCPT ); Thu, 11 Aug 2011 18:19:28 -0400 Received: from merit-proxy01.merit.edu ([207.75.116.193]:38140 "EHLO merit-proxy01.merit.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366Ab1HKWT1 (ORCPT ); Thu, 11 Aug 2011 18:19:27 -0400 X-Greylist: delayed 377 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Aug 2011 18:19:27 EDT Date: Thu, 11 Aug 2011 18:13:05 -0400 From: Jim Rees To: Boaz Harrosh Cc: Benny Halevy , Sorin Faibish , peter honeyman , tao.peng@emc.com, torvalds@linux-foundation.org, rdunlap@xenotime.net, bergwolf@gmail.com, Trond.Myklebust@netapp.com, linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, "Welch, Brent" Subject: Re: [PATCH] pnfs: Automatically select blocks & objects layouts Message-ID: <20110811221305.GA8608@merit.edu> References: <20110810122304.96b8be67.rdunlap@xenotime.net> <20110810175829.a834d80f.rdunlap@xenotime.net> <4E43AAD1.7090806@tonian.com> <4E4422FD.3060706@panasas.com> <4E444552.9030105@panasas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E444552.9030105@panasas.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Boaz Harrosh wrote: What about the below? based on v3.1-rc1 ---- From: Boaz Harrosh Subject: [PATCH] pnfs: Automatically select blocks & objects layouts Just like files-layout, blocks & objects layouts are part of the NFS 4.1 protocol and should be automatically selected if NFS_4_1 is selected. The small problem is that these depend on other Kernel support being present, while files only depends on NFS itself. This patch removes from the user choice the presence of objects and blocks layout. But makes sure these are selected only if the depended subsystems are present in the Kernel. Signed-off-by: Boaz Harrosh Acked-by: Jim Rees I think this is what we want. There is no point allowing the user to pick and choose various layout drivers. If they have selected nfs4.1 they should get all the layout drivers their kernel will support, based on the dependencies.