All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Schmidt <mschmidt@redhat.com>
To: eilong@broadcom.com
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Dmitry Kravkov" <dmitry@broadcom.com>,
	"Vladislav Zolotarov" <vladz@broadcom.com>
Subject: [PATCH] bnx2x: downgrade Max BW error message to debug
Date: Wed, 17 Aug 2011 17:50:37 +0200	[thread overview]
Message-ID: <20110817175037.2777724a@brian.englab.brq.redhat.com> (raw)
In-Reply-To: <1313498708.24298.0.camel@lb-tlvb-eilong.il.broadcom.com>

There are valid configurations where Max BW is configured to zero for
some VNs.
Print the message only if debugging is enabled and do not call the
configuration "illegal".

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>

---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
index 223bfee..8245e02 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h
@@ -1481,8 +1481,7 @@ static inline u16 bnx2x_extract_max_cfg(struct bnx2x *bp, u32 mf_cfg)
 	u16 max_cfg = (mf_cfg & FUNC_MF_CFG_MAX_BW_MASK) >>
 			      FUNC_MF_CFG_MAX_BW_SHIFT;
 	if (!max_cfg) {
-		BNX2X_ERR("Illegal configuration detected for Max BW - "
-			  "using 100 instead\n");
+		BNX2X_DBG_ERR("Max BW configured to 0 - using 100 instead\n");
 		max_cfg = 100;
 	}
 	return max_cfg;
-- 
1.7.6

  reply	other threads:[~2011-08-17 15:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 14:33 [PATCH] bnx2x: suppress repeated error messages about Max BW Michal Schmidt
2011-08-15 10:54 ` Eilon Greenstein
2011-08-15 11:59   ` Michal Schmidt
2011-08-15 12:33     ` Eilon Greenstein
2011-08-15 15:13       ` Michal Schmidt
2011-08-15 18:47         ` Eilon Greenstein
2011-08-16 11:38           ` Michal Schmidt
2011-08-16 12:45             ` Eilon Greenstein
2011-08-17 15:50               ` Michal Schmidt [this message]
2011-08-17 17:44                 ` [PATCH] bnx2x: downgrade Max BW error message to debug Eilon Greenstein
2011-08-18 11:37                   ` Michal Schmidt
2011-08-18 12:22                     ` Eilon Greenstein
2011-08-19  4:51                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110817175037.2777724a@brian.englab.brq.redhat.com \
    --to=mschmidt@redhat.com \
    --cc=dmitry@broadcom.com \
    --cc=eilong@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=vladz@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.