All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: x86_32_early_logical_apicid() -> one warning per CPU on late-determined BIGSMP systems
Date: Thu, 18 Aug 2011 13:59:21 +0200	[thread overview]
Message-ID: <20110818115921.GA20085@htj.dyndns.org> (raw)
In-Reply-To: <4E4D19820200007800051D19@nat28.tlf.novell.com>

Hello,

On Thu, Aug 18, 2011 at 12:54:10PM +0100, Jan Beulich wrote:
> >>> On 12.08.11 at 12:15, Tejun Heo <tj@kernel.org> wrote:
> > Ooh, okay, bigsmp switches apic pretty late in the init.  Wouldn't it
> > be better to move that to right after dmi init regardless of this
> > problem?
> 
> No, because this depends on knowing num_possible_cpus(), which
> in turn can't be done until after the firmware tables got parsed (and
> that's where the ->x86_32_early_logical_apicid() call happens).

OIC, switching apic that late seems rather nasty.  Eh well...  :(

> > So, yeah, please go ahead and remove it.
> 
> There are quite a few references to this, and some from code that
> if I change it I would have no way of testing (Summit, ES7000, NUMAQ).
> So no, I don't think I'm in the position to do this cleanup (if it really is
> just that).
> 
> So for the time being I'll put together a patch re-writing
> early_per_cpu(x86_cpu_to_logical_apicid, ...) right after overriding
> apic_default with apic_bigsmp.

Yeap, sure.  We'll need less invasive for -stable anyway.  I'll kill
the method afterwards.

Thanks.

-- 
tejun

      reply	other threads:[~2011-08-18 11:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 12:49 x86_32_early_logical_apicid() -> one warning per CPU on late-determined BIGSMP systems Jan Beulich
2011-08-12 10:15 ` Tejun Heo
2011-08-18 11:54   ` Jan Beulich
2011-08-18 11:59     ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110818115921.GA20085@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=JBeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.