All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package: add opencv
Date: Thu, 18 Aug 2011 14:34:28 +0200	[thread overview]
Message-ID: <20110818143428.160f2289@skate> (raw)
In-Reply-To: <1313645536-8381-1-git-send-email-s.martin49@gmail.com>

Hello,

Thanks for this new version, looks much better.

Le Thu, 18 Aug 2011 07:32:16 +0200,
Samuel Martin <s.martin49@gmail.com> a ?crit :

> +HOST_OPENCV_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENCV_BUILD_NEW_PYTHON_SUPPORT),host-python,)

Why do you need a host version of OpenCV ? I don't see where the
host-opencv package is being used.

Also, just a matter of taste, but I would prefer if you grouped
together the OPENCV_CONF_OPT += and OPENCV_DEPENDENCIES += lines
related to a given option. I.e, the lines:

+OPENCV_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENCV_BUILD_NEW_PYTHON_SUPPORT),python,)

and

+OPENCV_CONF_OPT += -DBUILD_NEW_PYTHON_SUPPORT=$(if $(BR2_PACKAGE_OPENCV_BUILD_NEW_PYTHON_SUPPORT),ON,OFF)

should be next to each other.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2011-08-18 12:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18  5:32 [Buildroot] [PATCH v2] package: add opencv Samuel Martin
2011-08-18 12:34 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110818143428.160f2289@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.