All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasiliy Kulikov <segoon@openwall.com>
To: kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] kmalloc() nofail allocations
Date: Mon, 22 Aug 2011 13:45:58 +0400	[thread overview]
Message-ID: <20110822094558.GA2620@albatros> (raw)
In-Reply-To: <20110822093819.GA13665@openwall.com>

Solar,

On Mon, Aug 22, 2011 at 13:38 +0400, Solar Designer wrote:
> On Mon, Aug 22, 2011 at 01:24:29PM +0400, Vasiliy Kulikov wrote:
> > Major problem with the idea in general:
> ...
> > Unlikely, but fully possible case - we want some memory and the OOM killer
> > kills us for our wish.
> 
> How/why is this a major problem with the idea in general?  I am probably
> missing something.

Initially I wanted to "wrap" kmalloc calls, which cannot fail in any
case.  This would not change any mm code, but the caller (its
expectation).

Now I see that it's impossible without any mm code changes.  It needs at
least __GFP_NOFAIL flag addition, which is explicitly marked as "no new
uses".  Such kmalloc_nofail() wouldn't differ much from kmalloc(size,
flags | __GFP_NOFAIL).


Thanks,

-- 
Vasiliy

  reply	other threads:[~2011-08-22  9:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17 19:15 [kernel-hardening] kmalloc() nofail allocations Vasiliy Kulikov
2011-08-20 14:27 ` [kernel-hardening] " Vasiliy Kulikov
2011-08-20 16:31   ` [kernel-hardening] " Solar Designer
2011-08-22  9:24     ` Vasiliy Kulikov
2011-08-22  9:38       ` Solar Designer
2011-08-22  9:45         ` Vasiliy Kulikov [this message]
2011-08-22  9:53           ` Solar Designer
2011-08-22 10:05             ` Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110822094558.GA2620@albatros \
    --to=segoon@openwall.com \
    --cc=kernel-hardening@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.