From: Samuel Ortiz <sameo@linux.intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: rjw@sisk.pl, menage@google.com, linux-kernel@vger.kernel.org,
arnd@arndb.de, oleg@redhat.com,
Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <padovan@profusion.mobi>,
wwang <wei_wang@realsil.com.cn>
Subject: Re: [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZE explicitly
Date: Mon, 22 Aug 2011 17:05:23 +0200 [thread overview]
Message-ID: <20110822150523.GZ4607@sortiz-mobl> (raw)
In-Reply-To: <1313763382-12341-3-git-send-email-tj@kernel.org>
Hi Tejun,
On Fri, Aug 19, 2011 at 04:16:08PM +0200, Tejun Heo wrote:
> Some drivers set PF_NOFREEZE in their kthread functions which is
> completely unnecessary and racy - some part of freezer code doesn't
> consider cases where PF_NOFREEZE is set asynchronous to freezer
> operations.
>
> In general, there's no reason to allow setting PF_NOFREEZE explicitly.
> Remove them and change the documentation to note that setting
> PF_NOFREEZE directly isn't allowed.
For the mfd parts:
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-08-22 15:03 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-19 14:16 [PATCHSET] freezer: fix various bugs and simplify implementation Tejun Heo
2011-08-19 14:16 ` [PATCH 01/16] freezer: fix current->state restoration race in refrigerator() Tejun Heo
2011-08-19 15:52 ` Oleg Nesterov
2011-08-19 16:11 ` Tejun Heo
2011-08-19 21:08 ` Rafael J. Wysocki
2011-08-20 8:13 ` Tejun Heo
2011-08-19 14:16 ` [PATCH 02/16] freezer: don't unnecessarily set PF_NOFREEZE explicitly Tejun Heo
2011-08-19 16:43 ` Gustavo Padovan
2011-08-22 15:05 ` Samuel Ortiz [this message]
2011-08-19 14:16 ` [PATCH 03/16] freezer: unexport refrigerator() and update try_to_freeze() slightly Tejun Heo
2011-08-19 14:16 ` [PATCH 04/16] freezer: implement and use kthread_freezable_should_stop() Tejun Heo
2011-08-19 20:07 ` Henrique de Moraes Holschuh
2011-08-21 19:14 ` Oleg Nesterov
2011-08-22 9:53 ` Tejun Heo
2011-08-23 15:42 ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 05/16] freezer: rename thaw_process() to __thaw_task() and simplify the implementation Tejun Heo
2011-08-19 15:37 ` Paul Menage
2011-08-24 2:28 ` Matt Helsley
2011-08-19 14:16 ` [PATCH 06/16] freezer: make exiting tasks properly unfreezable Tejun Heo
2011-08-23 15:52 ` Oleg Nesterov
2011-08-23 19:44 ` Tejun Heo
2011-08-24 14:14 ` Oleg Nesterov
2011-08-25 15:59 ` Tejun Heo
2011-08-25 16:56 ` Oleg Nesterov
2011-08-25 21:01 ` Rafael J. Wysocki
2011-08-25 21:54 ` Tejun Heo
2011-08-26 21:09 ` Rafael J. Wysocki
2011-08-27 10:35 ` Tejun Heo
2011-08-27 10:51 ` Rafael J. Wysocki
2011-08-27 11:02 ` Tejun Heo
2011-08-27 12:22 ` Rafael J. Wysocki
2011-08-25 21:52 ` Tejun Heo
2011-08-24 22:34 ` Matt Helsley
2011-08-25 15:25 ` Oleg Nesterov
2011-08-25 16:11 ` Tejun Heo
2011-08-19 14:16 ` [PATCH 07/16] freezer: don't distinguish nosig tasks on thaw Tejun Heo
2011-08-19 21:14 ` Rafael J. Wysocki
2011-08-20 8:10 ` Tejun Heo
2011-08-20 8:10 ` Tejun Heo
2011-08-20 8:39 ` Rafael J. Wysocki
2011-08-20 8:39 ` Rafael J. Wysocki
2011-08-19 21:14 ` Rafael J. Wysocki
2011-08-19 14:16 ` [PATCH 08/16] freezer: use dedicated lock instead of task_lock() + memory barrier Tejun Heo
2011-08-28 17:51 ` Oleg Nesterov
2011-08-28 18:21 ` Oleg Nesterov
2011-08-29 7:20 ` Tejun Heo
2011-08-19 14:16 ` [PATCH 09/16] freezer: make freezing indicate freeze condition in effect Tejun Heo
2011-08-28 17:56 ` Oleg Nesterov
2011-08-29 7:31 ` Tejun Heo
2011-08-29 17:44 ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 10/16] freezer: fix set_freezable[_with_signal]() race Tejun Heo
2011-08-28 18:01 ` Oleg Nesterov
2011-08-29 7:38 ` Tejun Heo
2011-08-19 14:16 ` [PATCH 11/16] freezer: kill PF_FREEZING Tejun Heo
2011-08-19 14:16 ` [PATCH 12/16] freezer: clean up freeze_processes() failure path Tejun Heo
2011-08-28 18:09 ` Oleg Nesterov
2011-08-29 7:28 ` Tejun Heo
2011-08-29 7:40 ` Rafael J. Wysocki
2011-08-19 14:16 ` [PATCH 13/16] cgroup_freezer: prepare for removal of TIF_FREEZE Tejun Heo
2011-08-19 15:40 ` Paul Menage
2011-08-28 17:39 ` Oleg Nesterov
2011-08-29 6:30 ` Tejun Heo
2011-08-19 14:16 ` [PATCH 14/16] freezer: make freezing() test freeze conditions in effect instead " Tejun Heo
2011-08-19 15:43 ` Paul Menage
2011-08-29 15:49 ` Oleg Nesterov
2011-08-29 15:56 ` Oleg Nesterov
2011-08-29 16:30 ` Oleg Nesterov
2011-08-29 16:17 ` Oleg Nesterov
2011-08-19 14:16 ` [PATCH 15/16] freezer: remove now unused TIF_FREEZE Tejun Heo
2011-08-19 14:16 ` [PATCH 16/16] freezer: remove should_send_signal() and update frozen() Tejun Heo
2011-08-19 14:23 ` [PATCHSET] freezer: fix various bugs and simplify implementation Tejun Heo
2011-08-19 15:34 ` Paul Menage
2011-08-19 16:25 ` Tejun Heo
2011-08-24 1:10 ` Matt Helsley
2011-08-19 21:00 ` Rafael J. Wysocki
2011-08-20 8:14 ` Tejun Heo
2011-08-20 8:14 ` Tejun Heo
2011-09-05 6:49 ` [BUG] CPU hotplug, freezer: Freezing of tasks failed after 20.00 seconds Srivatsa S. Bhat
2011-09-05 8:52 ` Srivatsa S. Bhat
2011-09-05 8:52 ` Srivatsa S. Bhat
2011-09-05 14:15 ` Tejun Heo
2011-09-06 5:08 ` Tejun Heo
2011-09-06 5:08 ` Tejun Heo
2011-09-06 6:01 ` Rafael J. Wysocki
2011-09-06 6:01 ` Rafael J. Wysocki
2011-10-02 19:13 ` Srivatsa S. Bhat
2011-10-02 19:33 ` Rafael J. Wysocki
2011-09-05 14:15 ` Tejun Heo
2011-08-19 21:00 ` [PATCHSET] freezer: fix various bugs and simplify implementation Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822150523.GZ4607@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=menage@google.com \
--cc=oleg@redhat.com \
--cc=padovan@profusion.mobi \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.