All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Michael Brade <brade@informatik.uni-muenchen.de>
Cc: netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: r8169 hard-freezes the system on big network loads
Date: Tue, 23 Aug 2011 15:17:26 +0200	[thread overview]
Message-ID: <20110823131726.GA21092@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20110821221140.GA20696@electric-eye.fr.zoreil.com>

Francois Romieu <romieu@fr.zoreil.com> :
[...]
> Yes. There is enough data for me to reproduce the bug with the
> exact same chipset.

I can not generate a single rx error and the driver refuses to crash :o/ 

Can you apply the patch below on top of 3.1.0-rc3 and see if it makes
a difference ?

Thanks.

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 02339b3..c54ed17 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -5326,10 +5326,6 @@ static int rtl8169_rx_interrupt(struct net_device *dev,
 				dev->stats.rx_length_errors++;
 			if (status & RxCRC)
 				dev->stats.rx_crc_errors++;
-			if (status & RxFOVF) {
-				rtl8169_schedule_work(dev, rtl8169_reset_task);
-				dev->stats.rx_fifo_errors++;
-			}
 			rtl8169_mark_to_asic(desc, rx_buf_sz);
 		} else {
 			struct sk_buff *skb;

  reply	other threads:[~2011-08-23 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-14 11:08 r8169 hard-freezes the system on big network loads Kjun Chen
2011-08-21 12:33 ` Francois Romieu
2011-08-21 13:20   ` Michael Brade
2011-08-21 22:11     ` Francois Romieu
2011-08-23 13:17       ` Francois Romieu [this message]
2011-09-11 20:16         ` Michael Brade
2011-09-13  8:11           ` Francois Romieu
2011-09-14 21:36             ` Michael Brade
2011-09-15  0:03               ` Francois Romieu
2011-09-15 10:26                 ` Michael Brade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823131726.GA21092@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=brade@informatik.uni-muenchen.de \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.