From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: kvm PCI assignment & VFIO ramblings Date: Wed, 24 Aug 2011 19:33:00 +1000 Message-ID: <20110824093300.GI30097@yookeroo.fritz.box> References: <20110823110431.GK2079@amd.com> <20110824091425.GE2079@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: aafabbri , Alexey Kardashevskiy , "kvm@vger.kernel.org" , Paul Mackerras , "linux-pci@vger.kernel.org" , qemu-devel , chrisw , iommu , Avi Kivity , Anthony Liguori , linuxppc-dev , "benve@cisco.com" To: "Roedel, Joerg" Return-path: Content-Disposition: inline In-Reply-To: <20110824091425.GE2079@amd.com> Sender: linux-pci-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Wed, Aug 24, 2011 at 11:14:26AM +0200, Roedel, Joerg wrote: > On Tue, Aug 23, 2011 at 12:54:27PM -0400, aafabbri wrote: > > On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > > > That is makes uiommu basically the same as the meta-groups, right? > > > > Yes, functionality seems the same, thus my suggestion to keep uiommu > > explicit. Is there some need for group-groups besides defining sets of > > groups which share IOMMU resources? > > > > I do all this stuff (bringing up sets of devices which may share IOMMU > > domain) dynamically from C applications. I don't really want some static > > (boot-time or sysfs fiddling) supergroup config unless there is a good > > reason KVM/power needs it. > > > > As you say in your next email, doing it all from ioctls is very easy, > > programmatically. > > I don't see a reason to make this meta-grouping static. It would harm > flexibility on x86. I think it makes things easier on power but there > are options on that platform to get the dynamic solution too. I think several people are misreading what Ben means by "static". I would prefer to say 'persistent', in that the meta-groups lifetime is not tied to an fd, but they can be freely created, altered and removed during runtime. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e23smtp09.au.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id CBEADB6F65 for ; Wed, 24 Aug 2011 19:33:16 +1000 (EST) Received: from /spool/local by au.ibm.com with XMail ESMTP for from ; Wed, 24 Aug 2011 10:30:15 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7O9VpJk1536166 for ; Wed, 24 Aug 2011 19:31:51 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7O9X6IC028572 for ; Wed, 24 Aug 2011 19:33:06 +1000 Date: Wed, 24 Aug 2011 19:33:00 +1000 From: David Gibson To: "Roedel, Joerg" Subject: Re: kvm PCI assignment & VFIO ramblings Message-ID: <20110824093300.GI30097@yookeroo.fritz.box> References: <20110823110431.GK2079@amd.com> <20110824091425.GE2079@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110824091425.GE2079@amd.com> Cc: chrisw , Alexey Kardashevskiy , "kvm@vger.kernel.org" , Paul Mackerras , "linux-pci@vger.kernel.org" , qemu-devel , aafabbri , iommu , Avi Kivity , Anthony Liguori , linuxppc-dev , "benve@cisco.com" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 24, 2011 at 11:14:26AM +0200, Roedel, Joerg wrote: > On Tue, Aug 23, 2011 at 12:54:27PM -0400, aafabbri wrote: > > On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > > > That is makes uiommu basically the same as the meta-groups, right? > > > > Yes, functionality seems the same, thus my suggestion to keep uiommu > > explicit. Is there some need for group-groups besides defining sets of > > groups which share IOMMU resources? > > > > I do all this stuff (bringing up sets of devices which may share IOMMU > > domain) dynamically from C applications. I don't really want some static > > (boot-time or sysfs fiddling) supergroup config unless there is a good > > reason KVM/power needs it. > > > > As you say in your next email, doing it all from ioctls is very easy, > > programmatically. > > I don't see a reason to make this meta-grouping static. It would harm > flexibility on x86. I think it makes things easier on power but there > are options on that platform to get the dynamic solution too. I think several people are misreading what Ben means by "static". I would prefer to say 'persistent', in that the meta-groups lifetime is not tied to an fd, but they can be freely created, altered and removed during runtime. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw9pr-0005XM-SL for qemu-devel@nongnu.org; Wed, 24 Aug 2011 05:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qw9pp-0005Au-Ib for qemu-devel@nongnu.org; Wed, 24 Aug 2011 05:33:23 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:55283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw9po-0005A7-T2 for qemu-devel@nongnu.org; Wed, 24 Aug 2011 05:33:21 -0400 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.31.245]) by e23smtp07.au.ibm.com (8.14.4/8.13.1) with ESMTP id p7O9X9mG023918 for ; Wed, 24 Aug 2011 19:33:09 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7O9X73m1839208 for ; Wed, 24 Aug 2011 19:33:09 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7O9X6IE028572 for ; Wed, 24 Aug 2011 19:33:07 +1000 Date: Wed, 24 Aug 2011 19:33:00 +1000 From: David Gibson Message-ID: <20110824093300.GI30097@yookeroo.fritz.box> References: <20110823110431.GK2079@amd.com> <20110824091425.GE2079@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110824091425.GE2079@amd.com> Subject: Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Roedel, Joerg" Cc: chrisw , Alexey Kardashevskiy , "kvm@vger.kernel.org" , Paul Mackerras , "linux-pci@vger.kernel.org" , qemu-devel , aafabbri , iommu , Avi Kivity , linuxppc-dev , "benve@cisco.com" On Wed, Aug 24, 2011 at 11:14:26AM +0200, Roedel, Joerg wrote: > On Tue, Aug 23, 2011 at 12:54:27PM -0400, aafabbri wrote: > > On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > > > That is makes uiommu basically the same as the meta-groups, right? > > > > Yes, functionality seems the same, thus my suggestion to keep uiommu > > explicit. Is there some need for group-groups besides defining sets of > > groups which share IOMMU resources? > > > > I do all this stuff (bringing up sets of devices which may share IOMMU > > domain) dynamically from C applications. I don't really want some static > > (boot-time or sysfs fiddling) supergroup config unless there is a good > > reason KVM/power needs it. > > > > As you say in your next email, doing it all from ioctls is very easy, > > programmatically. > > I don't see a reason to make this meta-grouping static. It would harm > flexibility on x86. I think it makes things easier on power but there > are options on that platform to get the dynamic solution too. I think several people are misreading what Ben means by "static". I would prefer to say 'persistent', in that the meta-groups lifetime is not tied to an fd, but they can be freely created, altered and removed during runtime. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson