From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= Subject: Re: [PATCH V3 0/3] xen-blkfront/xen-blkback trim support Date: Wed, 24 Aug 2011 17:17:54 +0300 Message-ID: <20110824141754.GZ32373@reaktio.net> References: <1314177825-22360-1-git-send-email-lidongyang@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1314177825-22360-1-git-send-email-lidongyang@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Li Dongyang Cc: xen-devel@lists.xensource.com, owen.smith@citrix.com, JBeulich@novell.com List-Id: xen-devel@lists.xenproject.org On Wed, Aug 24, 2011 at 05:23:42PM +0800, Li Dongyang wrote: > Dear list, > this is the V3 of the trim support for xen-blkfront/blkback, Isn't the generic name for this functionality "discard" in Linux? and "trim" being the ATA specific discard-implementation, and "scsi unmap" the SAS/SCSI specific discard-implementation? Just wondering.. -- Pasi > thanks for all your reviews. > and when I looked back at Owen's patch in Dec 2010, > http://lists.xensource.com/archives/html/xen-devel/2010-12/msg00299.html > this patch above also add the trim union to blkif_x86_{32|64}_request, > and take care of trim request in blkif_get_x86{32|64}_req(), > however, in the later versions, the part is just gone. I wonder if it is > needed here? Thanks. > > Changelog V3: > rebased on linus's tree > enum backend types in blkif instead of flags in the interface header > more reasonable names in xenstore > move trim requesting handling to a separate function > do not re-enable interrupts unconditionally when handling response > set info->feature-trim only when we have all info needed for request queue > Changelog V2: > rebased on Jeremy's tree > fixes according to Jan Beulich's comments > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel