From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887Ab1HYDus (ORCPT ); Wed, 24 Aug 2011 23:50:48 -0400 Received: from oproxy3-pub.bluehost.com ([69.89.21.8]:56326 "HELO oproxy3-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751433Ab1HYDuq (ORCPT ); Wed, 24 Aug 2011 23:50:46 -0400 Date: Wed, 24 Aug 2011 20:50:44 -0700 From: Randy Dunlap To: Cong Wang Cc: Andrew Morton , Stephen Rothwell , gregkh@suse.de, linux-next@vger.kernel.org, LKML , linux-mm@kvack.org Subject: Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c Message-Id: <20110824205044.7ff45b6c.rdunlap@xenotime.net> In-Reply-To: <4E55C221.8080100@redhat.com> References: <20110804145834.3b1d92a9eeb8357deb84bf83@canb.auug.org.au> <20110804152211.ea10e3e7.rdunlap@xenotime.net> <20110823143912.0691d442.akpm@linux-foundation.org> <4E547155.8090709@redhat.com> <20110824191430.8a908e70.rdunlap@xenotime.net> <4E55C221.8080100@redhat.com> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Aug 2011 11:31:45 +0800 Cong Wang wrote: > 于 2011年08月25日 10:14, Randy Dunlap 写道: > > On Wed, 24 Aug 2011 11:34:45 +0800 Cong Wang wrote: > > > >> Hi, Andrew, > >> > >> Do you think my patch below is better? > > > > Hi, > > > > This causes build errors for me because node.o is not being built: > > > > arch/x86/built-in.o: In function `topology_init': > > topology.c:(.init.text+0x3668): undefined reference to `register_one_node' > > drivers/built-in.o: In function `unregister_cpu': > > (.text+0x7aecc): undefined reference to `unregister_cpu_under_node' > > drivers/built-in.o: In function `register_cpu': > > (.cpuinit.text+0xc1): undefined reference to `register_cpu_under_node' > > Ah, this is because I missed the part in include/linux/node.h. :) > > Below is the updated version. > > Thanks for testing! Yes, that works after changing #ifdef defined(...) to #if defined(...) Acked-by: Randy Dunlap --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id 2163B6B0169 for ; Wed, 24 Aug 2011 23:50:48 -0400 (EDT) Date: Wed, 24 Aug 2011 20:50:44 -0700 From: Randy Dunlap Subject: Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c Message-Id: <20110824205044.7ff45b6c.rdunlap@xenotime.net> In-Reply-To: <4E55C221.8080100@redhat.com> References: <20110804145834.3b1d92a9eeb8357deb84bf83@canb.auug.org.au> <20110804152211.ea10e3e7.rdunlap@xenotime.net> <20110823143912.0691d442.akpm@linux-foundation.org> <4E547155.8090709@redhat.com> <20110824191430.8a908e70.rdunlap@xenotime.net> <4E55C221.8080100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Cong Wang Cc: Andrew Morton , Stephen Rothwell , gregkh@suse.de, linux-next@vger.kernel.org, LKML , linux-mm@kvack.org On Thu, 25 Aug 2011 11:31:45 +0800 Cong Wang wrote: > ao? 2011a1'08ae??25ae?JPY 10:14, Randy Dunlap a??e??: > > On Wed, 24 Aug 2011 11:34:45 +0800 Cong Wang wrote: > > > >> Hi, Andrew, > >> > >> Do you think my patch below is better? > > > > Hi, > > > > This causes build errors for me because node.o is not being built: > > > > arch/x86/built-in.o: In function `topology_init': > > topology.c:(.init.text+0x3668): undefined reference to `register_one_node' > > drivers/built-in.o: In function `unregister_cpu': > > (.text+0x7aecc): undefined reference to `unregister_cpu_under_node' > > drivers/built-in.o: In function `register_cpu': > > (.cpuinit.text+0xc1): undefined reference to `register_cpu_under_node' > > Ah, this is because I missed the part in include/linux/node.h. :) > > Below is the updated version. > > Thanks for testing! Yes, that works after changing #ifdef defined(...) to #if defined(...) Acked-by: Randy Dunlap --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org