From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 25 Aug 2011 10:51:32 -0400 Subject: [U-Boot] gcc-4.6 warnings In-Reply-To: <7056F5B1-AD6C-459E-80F1-8EE436CC781A@kernel.crashing.org> References: <3AA0E5B6-7E38-4CB0-94E2-F7BBA9A100FA@kernel.crashing.org> <20110825055226.91C9211F9E74@gemini.denx.de> <7056F5B1-AD6C-459E-80F1-8EE436CC781A@kernel.crashing.org> Message-ID: <201108251051.33986.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, August 25, 2011 10:27:42 Kumar Gala wrote: > On Aug 25, 2011, at 12:52 AM, Wolfgang Denk wrote: > > Kumar Gala wrote: > >>> If the variable is not used, why don't we remove it, then? > >> > >> In the vast number of cases it because of some #ifdef case not be > >> defined in the given build. > > > > well, that's the reason for the warnings showing up, it isn't the > > reason why we cannot fix these? > : > :), Thus my query if we really wanted to try and fix them by adding more > :#ifdef's or live with that as an acceptable thing to do. i feel like some (many?) #ifdef's in the tree could be done without ifdefs (by relying on gcc's DCE) thus improving overall code quality -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110825/6669ba99/attachment.pgp