From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754487Ab1HYPVg (ORCPT ); Thu, 25 Aug 2011 11:21:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14957 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753631Ab1HYPVf (ORCPT ); Thu, 25 Aug 2011 11:21:35 -0400 Date: Thu, 25 Aug 2011 17:18:18 +0200 From: Oleg Nesterov To: Michal Hocko Cc: David Rientjes , Konstantin Khlebnikov , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, KOSAKI Motohiro , KAMEZAWA Hiroyuki Subject: Re: [PATCH] oom: skip frozen tasks Message-ID: <20110825151818.GA4003@redhat.com> References: <20110823073101.6426.77745.stgit@zurg> <20110824101927.GB3505@tiehlicka.suse.cz> <20110825091920.GA22564@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110825091920.GA22564@tiehlicka.suse.cz> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/25, Michal Hocko wrote: > > On Wed 24-08-11 12:31:26, David Rientjes wrote: > > > > That's obviously false since we call oom_killer_disable() in > > freeze_processes() to disable the oom killer from ever being called in the > > first place, so this is something you need to resolve with Rafael before > > you cause more machines to panic. > > I didn't mean suspend/resume path (that is protected by oom_killer_disabled) > so the patch doesn't make any change. Confused... freeze_processes() does try_to_freeze_tasks() before oom_killer_disable() ? Oleg. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with SMTP id 069CA6B016A for ; Thu, 25 Aug 2011 11:21:20 -0400 (EDT) Date: Thu, 25 Aug 2011 17:18:18 +0200 From: Oleg Nesterov Subject: Re: [PATCH] oom: skip frozen tasks Message-ID: <20110825151818.GA4003@redhat.com> References: <20110823073101.6426.77745.stgit@zurg> <20110824101927.GB3505@tiehlicka.suse.cz> <20110825091920.GA22564@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110825091920.GA22564@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: David Rientjes , Konstantin Khlebnikov , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, KOSAKI Motohiro , KAMEZAWA Hiroyuki On 08/25, Michal Hocko wrote: > > On Wed 24-08-11 12:31:26, David Rientjes wrote: > > > > That's obviously false since we call oom_killer_disable() in > > freeze_processes() to disable the oom killer from ever being called in the > > first place, so this is something you need to resolve with Rafael before > > you cause more machines to panic. > > I didn't mean suspend/resume path (that is protected by oom_killer_disabled) > so the patch doesn't make any change. Confused... freeze_processes() does try_to_freeze_tasks() before oom_killer_disable() ? Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org