From mboxrd@z Thu Jan 1 00:00:00 1970 From: KAMEZAWA Hiroyuki Subject: Re: [PATCH 4/6] cgroup: don't use subsys->can_attach_task() or ->attach_task() Date: Fri, 26 Aug 2011 13:18:05 +0900 Message-ID: <20110826131805.7b835bd1.kamezawa.hiroyu__16282.3551371277$1314333123$gmane$org@jp.fujitsu.com> References: <1314312192-26885-1-git-send-email-tj@kernel.org> <1314312192-26885-5-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1314312192-26885-5-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tejun Heo Cc: fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Ingo Molnar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rjw-KKrjLPT3xs0@public.gmane.org, Daisuke Nishimura , linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, paul-inf54ven1CmVyaH7bEyXVA@public.gmane.org List-Id: containers.vger.kernel.org On Fri, 26 Aug 2011 00:43:10 +0200 Tejun Heo wrote: > Now that subsys->can_attach() and attach() take @tset instead of > @task, they can handle per-task operations. Convert > ->can_attach_task() and ->attach_task() users to use ->can_attach() > and attach() instead. Most converions are straight-forward. > Noteworthy changes are, > > * In cgroup_freezer, remove unnecessary NULL assignments to unused > methods. It's useless and very prone to get out of sync, which > already happened. > > * In cpuset, PF_THREAD_BOUND test is checked for each task. This > doesn't make any practical difference but is conceptually cleaner. > > Signed-off-by: Tejun Heo > Cc: Paul Menage > Cc: Li Zefan > Cc: Balbir Singh > Cc: Daisuke Nishimura > Cc: KAMEZAWA Hiroyuki > Cc: James Morris > Cc: Ingo Molnar > Cc: Peter Zijlstra Reviewed-by: KAMEZAWA Hiroyuki