From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754454Ab1HZPke (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Aug 2011 11:40:34 -0400
Received: from charlotte.tuxdriver.com ([70.61.120.58]:55265 "EHLO
	smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753996Ab1HZPkc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Aug 2011 11:40:32 -0400
Date: Fri, 26 Aug 2011 11:39:40 -0400
From: Neil Horman <nhorman@tuxdriver.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Jovi Zhang <bookjovi@gmail.com>,
        =?iso-8859-1?Q?P=E1draig?= Brady <P@draigbrady.com>,
        dhowells@redhat.com, roland@redhat.com, viro@zeniv.linux.org.uk,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coredump: fix pipe coredump when core limit is 0
Message-ID: <20110826153940.GA23556@hmsreliant.think-freely.org>
References: <48dnn9u5x3e4qoh8meht42xk.1313966177259@email.android.com>
 <4E527684.3020206@draigBrady.com>
 <20110822161914.GA9399@redhat.com>
 <CACV3sbJjDhzKq8YQEnrTQPVVw7YsZjLe45G5sWaMRBk3+Vxkcg@mail.gmail.com>
 <20110824110134.GA17362@hmsreliant.think-freely.org>
 <20110825155735.GA5380@redhat.com>
 <20110825184313.GA29763@hmsreliant.think-freely.org>
 <20110826141139.GB13620@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110826141139.GB13620@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Score: 0.1 (/)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2011 at 04:11:39PM +0200, Oleg Nesterov wrote:
> On 08/25, Neil Horman wrote:
> >
> > On Thu, Aug 25, 2011 at 05:57:35PM +0200, Oleg Nesterov wrote:
> > > On 08/24, Neil Horman wrote:
> > > >
> > > > The long and the short of it is, making RLIMIT_CORE == 0 for the ispipe case
> > > > skip the core dump, breaks lots of user space expectations
> > >
> > > Not sure this really makes sense, but perhaps ispipe can skip the dump
> > > if RLIMIT_CORE == 0 _and_ the signal was sent from the user-space.
> > >
> > If you can guarantee that the signal came from user space, yes, that would work
> > I imagine.
> 
> No, I was wrong.
> 
> > alternatively I expect we could modify the kernel thread creation
> > routine such that it sets PR_SET_DUMPABLE to zero for all kernel threads
> 
> Just curious... why?
> 
Sorry, I read your words above backwards.  I was trying to suggest an equivalent
solution, but my idea was quite inverted.
Neil

> Oleg.
> 
>