All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Alex Deucher <alexdeucher@gmail.com>, Dave Airlie <airlied@gmail.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
	"Pavel Ivanov" <paivanof@gmail.com>,
	"Michel Dänzer" <michel@daenzer.net>,
	dri-devel@lists.freedesktop.org,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Kernel almost hangs when CONFIG_DRM_RADEON=y
Date: Mon, 29 Aug 2011 16:16:12 +0200	[thread overview]
Message-ID: <20110829141612.GB2025@gere.osrc.amd.com> (raw)
In-Reply-To: <CADnq5_Mppeym2spCqsRGYALQxWDjQ_yNuta4SYRH6Oocy=UjSg@mail.gmail.com>

On Mon, Aug 29, 2011 at 09:48:22AM -0400, Alex Deucher wrote:
> >> Should we make Kconfig pop up a dialog and ask for the whereabouts of
> >> these firmware thingies when you mark the driver =y?
> >>
> >> This all sounds like magic to me, having to know you need to add to
> >> EXTRA_FIRMWARE, having to know what file it needs etc.. For all intents
> >> and purposes =y just doesn't work and that's broken.
> >
> > Yep, you make a lot of sense. I had to fumble the build/reboot cycle a
> > couple of times and do some code staring even to figure this out. In
> > the end, I copied the whole radeon/ folder from David's firmware git
> > repo into /lib/firmware and made radeon.ko =m again so that I don't have
> > to add *.bin entries to CONFIG_EXTRA_FIRMWARE each time I'm building a
> > kernel on a different machine.
> >
> > Besides, there was this other issue on lkml today where
> > CONFIG_EXTRA_FIRMWARE can cause nconf to segfault when you overflow
> > its length of 256 by trying to include a bunch of firmware *bin files:
> > http://lkml.org/lkml/2011/8/29/86
> 
> If you are going to build the ucode into your kernel you'll need to
> pick the ones you want to include or increase the limit regardless of
> whether it's radeon ucode or ucode for some other chip.  For a
> particular card you only need the ones for that card (e.g.,
> CEDAR_*.bin or REDWOOD_*.bin, etc.)

Alex, Dave, yeah, that's all fine.

The question Peter asked is, how to make this much more understandable
to the user so that she/he doesn't have to figure it out on their own.
IOW, if one sets RADEON to =y in Kconfig, it should automatically
generate a selection menu with all the firmware required so that
the user can select from it either the CEDAR* or the REDWOOD* (or
the DOUGHNUT* :-)) ones for her/his card and when the user selects
one entry, the required strings are added to CONFIG_EXTRA_FIRMWARE
_automatically_.

Maybe even Kbuild should try to find them on the system, and, if unable
to, remind the user to install the needed firmware package.

Anyway, something to that effect, the above is just to illustrate the
intention, I don't know whether it would work. In any case, we're
lacking user help there and we don't want to put every user through
the process of finding which firmware files she/he needs when setting
RADEON=y.

Does that make more sense?

-- 
Regards/Gruss,
Boris.


  reply	other threads:[~2011-08-29 14:16 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-27  4:20 Kernel almost hangs when CONFIG_DRM_RADEON=y Pavel Ivanov
2011-08-27  9:00 ` Michel Dänzer
2011-08-27 22:50   ` Pavel Ivanov
2011-08-28  5:36     ` Borislav Petkov
2011-08-28 21:47       ` Pavel Ivanov
2011-08-28 21:47         ` Pavel Ivanov
2011-08-29  5:49         ` Borislav Petkov
2011-08-29  6:04           ` Michel Dänzer
2011-08-29  6:04             ` Michel Dänzer
2011-08-29 13:20       ` Peter Zijlstra
2011-08-29 13:38         ` Borislav Petkov
2011-08-29 13:43           ` Dave Airlie
2011-08-29 13:48           ` Alex Deucher
2011-08-29 14:16             ` Borislav Petkov [this message]
2011-08-29 15:47               ` David Airlie
2011-08-29 15:55                 ` Borislav Petkov
2011-08-29 16:10                   ` Arnaud Lacombe
2011-08-29 16:10                     ` Arnaud Lacombe
2011-08-29 17:17                     ` Borislav Petkov
2011-08-29 17:38                       ` Michel Dänzer
2011-08-29 17:38                         ` Michel Dänzer
2011-08-29 17:50                       ` Peter Zijlstra
2011-08-29 18:09                       ` Peter Zijlstra
2011-08-29 18:16                       ` Peter Zijlstra
2011-08-29 21:14                         ` Borislav Petkov
2011-08-30  2:08                           ` Henrique de Moraes Holschuh
2011-08-30  2:08                           ` Henrique de Moraes Holschuh
2011-08-30  7:17                             ` Borislav Petkov
2011-08-30  7:17                               ` Borislav Petkov
2011-08-30 14:44                               ` Henrique de Moraes Holschuh
2011-08-30 14:44                               ` Henrique de Moraes Holschuh
2011-08-30  8:37                             ` Peter Zijlstra
2011-08-30 14:55                               ` Henrique de Moraes Holschuh
2011-08-29 16:28             ` Kyle Moffett
2011-08-29 17:21               ` Borislav Petkov
2011-08-29 17:51                 ` Peter Zijlstra
2011-08-27 23:03   ` Kyle Moffett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110829141612.GB2025@gere.osrc.amd.com \
    --to=bp@alien8.de \
    --cc=airlied@gmail.com \
    --cc=alexdeucher@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=paivanof@gmail.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.