From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 31 Aug 2011 16:22:17 -0400 Subject: [U-Boot] [PATCH V4] console: Implement pre-console buffer In-Reply-To: References: <1314794155-14186-1-git-send-email-graeme.russ@gmail.com> <20110831191822.33F9A18C46FA@gemini.denx.de> Message-ID: <201108311622.19275.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, August 31, 2011 16:05:38 Simon Glass wrote: > On Wed, Aug 31, 2011 at 12:18 PM, Wolfgang Denk wrote: > > Simon Glass wrote: > >> nit: circular. Just a suggestion if you like: you could also offer > >> guidance for the location of the buffer, something like: > >> > >> You can place the buffer at the top of memory by adding something like > >> this in your board config file: > >> > >> #define CONFIG_PRE_CON_BUF_ADDR (CONFIG_SYS_INIT_RAM_ADDR > >> + \ CONFIG_SYS_INIT_RAM_SIZE - \ CONFIG_PRE_CON_BUF_SZ) > >> #define CONFIG_SYS_INIT_SP_ADDR (CONFIG_PRE_CON_BUF_ADDR - > >> \ GENERATED_GBL_DATA_SIZE) > > > > That would only make sense if these were generic options that are used > > across all boards and architectures. > > Yes ok - its' already decided not to put this code in arch/xxx/board.c > so let's leave this out then. fwiw, i'll probably do that in Blackfin's default arch config.h so that boards get a sane default that'll work across all Blackfin cpus -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110831/45df982a/attachment.pgp