All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, jirislaby@gmail.com,
	Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 3/4] TTY: serial, fix build of some drivers
Date: Wed, 31 Aug 2011 22:28:50 +0100	[thread overview]
Message-ID: <20110831222850.494bf19d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1314818699-10873-3-git-send-email-jslaby@suse.cz>

On Wed, 31 Aug 2011 21:24:58 +0200
Jiri Slaby <jslaby@suse.cz> wrote:

> I'm getting build errors such as:
> .../tty/serial/max3107.c: In function ‘put_data_to_circ_buf’:
> .../tty/serial/max3107.c:149:2: error: implicit declaration of function ‘tty_insert_flip_string’
> 
> Those drivers need to include linux/tty_flip.h. The question is
> whether we want to fix them at all. As they are broken for some time
> already and nobody noticed...

Config options randomly including it ?

  reply	other threads:[~2011-08-31 21:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 19:24 [PATCH 1/4] TTY: serial, fix locking imbalance Jiri Slaby
2011-08-31 19:24 ` [PATCH 2/4] TTY: serial, remove dead code from 68328 Jiri Slaby
2011-08-31 19:24   ` Jiri Slaby
2011-08-31 19:51   ` Geert Uytterhoeven
2011-08-31 19:51     ` Geert Uytterhoeven
2011-08-31 19:51     ` Geert Uytterhoeven
2011-08-31 19:51       ` Geert Uytterhoeven
2011-08-31 19:51     ` Geert Uytterhoeven
2011-08-31 19:51   ` Geert Uytterhoeven
2011-08-31 19:24 ` [PATCH 3/4] TTY: serial, fix build of some drivers Jiri Slaby
2011-08-31 19:24   ` Jiri Slaby
2011-08-31 21:28   ` Alan Cox [this message]
2011-09-01  8:29     ` Jiri Slaby
2011-09-01  8:29       ` Jiri Slaby
2011-09-01 14:20   ` [PATCH v2 3/4] TTY: serial, fix includes in " Jiri Slaby
2011-09-01 14:20     ` Jiri Slaby
2011-08-31 19:24 ` [PATCH 4/4] TTY: serial, move 68360 driver to staging Jiri Slaby
2011-08-31 19:24   ` Jiri Slaby
2011-08-31 19:31   ` Sasha Levin
2011-08-31 19:31   ` Sasha Levin
2011-08-31 19:31     ` Sasha Levin
2011-08-31 19:37     ` [PATCH "find-renames version" " Jiri Slaby
2011-08-31 19:41     ` [PATCH " Greg KH
2011-08-31 19:41       ` Greg KH
2011-08-31 19:52   ` Geert Uytterhoeven
2011-08-31 19:52     ` Geert Uytterhoeven
2011-09-22 18:30 ` [PATCH 1/4] TTY: serial, fix locking imbalance Jiri Slaby
2011-09-22 18:38   ` Greg KH
2011-09-22 22:46 ` Greg KH
2011-09-23 18:52   ` Jiri Slaby
2011-09-23 19:08     ` Greg KH
2011-09-23 19:21       ` Jiri Slaby
2011-09-23 22:04         ` Greg KH
2011-09-24 17:50           ` Jiri Slaby
2011-09-26 23:36             ` Greg KH
2011-09-27  8:26               ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110831222850.494bf19d@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.