From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 01 Sep 2011 07:51:05 +0200
Subject: [U-Boot] [PATCH] s5p-mmc: Fix ambiguous setting of data
	transfer width
In-Reply-To: <CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg@mail.gmail.com>
References: <1314701731-19099-1-git-send-email-chander.kashyap@linaro.org>
	<CAKWjMd51_TtqdwNrNAarQyLMCS=CB+A_v-YEn_KMW_7i-OhwMA@mail.gmail.com>
	<CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg@mail.gmail.com>
Message-ID: <20110901055105.E1847166C886@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Minkyu Kang,

In message <CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg@mail.gmail.com> you wrote:
> 
> > I know these were like this before, but those numbers are awfully
> > magical. You should really define constants for them.
> 
> We decided to use comments instead of defines.

And now we ask you to fix this, because we don;t want such magic
constants.  So please go on and change this.

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra