From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzI5d-0007Eu-K4 for qemu-devel@nongnu.org; Thu, 01 Sep 2011 20:58:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzI5b-0004Gb-3f for qemu-devel@nongnu.org; Thu, 01 Sep 2011 20:58:37 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:60779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzI5a-0004GM-Iq for qemu-devel@nongnu.org; Thu, 01 Sep 2011 20:58:35 -0400 Received: from /spool/local by au.ibm.com with XMail ESMTP for from ; Fri, 2 Sep 2011 01:55:11 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p820taC91376450 for ; Fri, 2 Sep 2011 10:55:36 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p820v53Z015957 for ; Fri, 2 Sep 2011 10:57:06 +1000 Date: Fri, 2 Sep 2011 10:39:16 +1000 From: David Gibson Message-ID: <20110902003916.GQ11906@yookeroo.fritz.box> References: <1314853263-2086-1-git-send-email-david@gibson.dropbear.id.au> <1314853263-2086-2-git-send-email-david@gibson.dropbear.id.au> <20110901153550.GC10989@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110901153550.GC10989@redhat.com> Subject: Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, joerg.roedel@amd.com, qemu-devel@nongnu.org, agraf@suse.de, eduard.munteanu@linux360.ro, rth@twiddle.net On Thu, Sep 01, 2011 at 06:35:51PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 01, 2011 at 03:00:54PM +1000, David Gibson wrote: [snip] > > +DECLARE_LDST_DMA(ub, b, 8); > > +DECLARE_LDST_DMA(uw, w, 16); > > +DECLARE_LDST_DMA(l, l, 32); > > +DECLARE_LDST_DMA(q, q, 64); > > + > > +#undef DECLARE_LDST_DMA > > + > > #endif > > I'd prefer the stubs to be inline. Not just as an optimization: > it also makes it easier to grok what goes on in the common > no-iommu case. So would I, but that doesn't work because of the poisonong of the phys access functions. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson