All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] coldfire: Change timer_init return type from void to int
Date: Fri, 02 Sep 2011 09:52:26 +0200	[thread overview]
Message-ID: <20110902075226.3B1F9137213A@gemini.denx.de> (raw)
In-Reply-To: <201108301111.00896.vapier@gentoo.org>

Dear Mike Frysinger,

In message <201108301111.00896.vapier@gentoo.org> you wrote:
>
...
> you should have gotten a build error as the prototype is in common.h.  so=20
> please add an include for common.h to this file.
...
> drop the extern and include common.h
...

When requesting changes to a patch, can you (and everybody else!)

*** P L E A S E ***

update the patch state in Patchworks to "Changes requested" ?

Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only person who always got his work done by Friday
                                                 was Robinson Crusoe.

  reply	other threads:[~2011-09-02  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 13:00 [U-Boot] [PATCH 1/5] coldfire: Change timer_init return type from void to int stany MARCEL
2011-08-30 15:10 ` Mike Frysinger
2011-09-02  7:52   ` Wolfgang Denk [this message]
2011-08-31 12:09 ` [U-Boot] [PATCH v2 " y at theia.denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110902075226.3B1F9137213A@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.