From: Christoph Hellwig <hch@infradead.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/4] Btrfs: fix defragmentation regression
Date: Fri, 2 Sep 2011 04:42:08 -0400 [thread overview]
Message-ID: <20110902084208.GA28209@infradead.org> (raw)
In-Reply-To: <4E608C29.10307@cn.fujitsu.com>
On Fri, Sep 02, 2011 at 03:56:25PM +0800, Li Zefan wrote:
> There's an off-by-one bug:
>
> # create a file with lots of 4K file extents
> # btrfs fi defrag /mnt/file
> # sync
> # filefrag -v /mnt/file
> Filesystem type is: 9123683e
> File size of /mnt/file is 1228800 (300 blocks, blocksize 4096)
> ext logical physical expected length flags
> 0 0 3372 64
> 1 64 3136 3435 1
> 2 65 3436 3136 64
> 3 129 3201 3499 1
> 4 130 3500 3201 64
> 5 194 3266 3563 1
> 6 195 3564 3266 64
> 7 259 3331 3627 1
> 8 260 3628 3331 40 eof
>
> After this patch:
Can you please create an xfstests testcase for this?
next prev parent reply other threads:[~2011-09-02 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 7:56 [PATCH 1/4] Btrfs: fix defragmentation regression Li Zefan
2011-09-02 7:56 ` [PATCH 2/4] Btrfs: use i_size_read() in btrfs_defrag_file() Li Zefan
2011-09-22 10:58 ` David Sterba
2011-09-02 7:56 ` [PATCH 3/4] Btrfs: fix wrong max_to_defrag " Li Zefan
2011-09-22 10:42 ` David Sterba
2011-09-02 7:57 ` [PATCH 4/4] Btrfs: honor extent thresh during defragmentation Li Zefan
2011-09-02 8:42 ` Christoph Hellwig [this message]
2011-10-18 8:48 ` [PATCH 1/4] Btrfs: fix defragmentation regression Dan Merillat
2011-10-18 8:52 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902084208.GA28209@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.