All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Bob Pearson <rpearson@systemfabricworks.com>
Cc: linux-kernel@vger.kernel.org, fzago@systemfabricworks.com,
	Joakim Tjernlund <joakim.tjernlund@transmode.se>,
	George Spelvin <linux@horizon.com>
Subject: Re: [PATCH v6 00/10] crc32
Date: Fri, 2 Sep 2011 16:50:20 -0700	[thread overview]
Message-ID: <20110902165020.7c6b5382.akpm@linux-foundation.org> (raw)
In-Reply-To: <4E5EB5CC.1010605@systemfabricworks.com>

On Wed, 31 Aug 2011 17:29:32 -0500
Bob Pearson <rpearson@systemfabricworks.com> wrote:

> This is an attempt to resolve all the issues that were left in the last review.
> There is one proposed change that is still causing a difference of opinion
> which has to do with the form of the loops and their performance on x86 and ppc
> This version has the change to the form that runs faster on x86 as an ifdef.
> 
> This patch series provides improved performance for computing the crc32
> polynomial on common hardware by adding the Slicing-by-8 algorithm to the
> existing algorithms already included. The new algorithm is very closely
> related to the existing algorithm so the extension requires small changes
> to implement.  Additionally it cleans up some warnings in the existing
> code and adds a kernel mode optional self test to replace the existing
> user mode self test.
> 
> A description of the existing and new algorithm is included in
> Documentation/crc32.txt.

So...  are the crc wars over yet?  I hope it's safe to look at the
patches now ;)

Please see Documentation/SubmittingPatches Section 15's discussion of
patch Subject: lines.

Is there any code in the kernel which uses the crc code so much that we
actually care about its performance?


  reply	other threads:[~2011-09-02 23:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31 22:29 [PATCH v6 00/10] crc32 Bob Pearson
2011-09-02 23:50 ` Andrew Morton [this message]
2011-09-03  9:32   ` Joakim Tjernlund
2011-09-06 16:02   ` Bob Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110902165020.7c6b5382.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fzago@systemfabricworks.com \
    --cc=joakim.tjernlund@transmode.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=rpearson@systemfabricworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.