From: Stephen Hemminger <shemminger@vyatta.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 1/2] bridge: leave carrier on for empty bridge
Date: Fri, 02 Sep 2011 10:22:21 -0700 [thread overview]
Message-ID: <20110902172247.396753508@vyatta.com> (raw)
In-Reply-To: 20110902172220.830228928@vyatta.com
[-- Attachment #1: br-carrier-default.patch --]
[-- Type: text/plain, Size: 955 bytes --]
This resolves a regression seen by some users of bridging.
Some users use the bridge like a dummy device.
They expect to be able to put an IPv6 address on the device
with no ports attached during boot.
Note: the bridge still will reflect the state of ports in the
bridge if there are any added.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
This fix needs to go to stable for 3.0 and 2.6.39
--- a/net/bridge/br_device.c 2011-09-01 08:52:27.596631192 -0700
+++ b/net/bridge/br_device.c 2011-09-01 09:01:03.256611801 -0700
@@ -91,7 +91,6 @@ static int br_dev_open(struct net_device
{
struct net_bridge *br = netdev_priv(dev);
- netif_carrier_off(dev);
netdev_update_features(dev);
netif_start_queue(dev);
br_stp_enable_bridge(br);
@@ -108,8 +107,6 @@ static int br_dev_stop(struct net_device
{
struct net_bridge *br = netdev_priv(dev);
- netif_carrier_off(dev);
-
br_stp_disable_bridge(br);
br_multicast_stop(br);
next parent reply other threads:[~2011-09-02 17:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110902172220.830228928@vyatta.com>
2011-09-02 17:22 ` Stephen Hemminger [this message]
2011-09-02 21:39 ` [PATCH 1/2] bridge: leave carrier on for empty bridge Nicolas de Pesloüan
2011-09-02 22:11 ` Stephen Hemminger
2011-09-03 2:15 ` Ang Way Chuang
2011-09-03 6:30 ` Stephen Hemminger
2011-09-25 8:55 ` Marc Haber
2011-09-03 18:32 ` Nicolas de Pesloüan
2011-09-04 4:14 ` Stephen Hemminger
2011-09-04 7:35 ` Nicolas de Pesloüan
2011-09-04 16:36 ` Stephen Hemminger
2011-09-04 17:12 ` Krzysztof Olędzki
2011-09-05 4:51 ` Ang Way Chuang
2011-09-05 17:18 ` Nicolas de Pesloüan
2011-09-05 17:57 ` Stephen Hemminger
2011-09-05 19:02 ` Ang Way Chuang
2011-09-05 22:45 ` Stephen Hemminger
2011-09-06 6:52 ` Nicolas de Pesloüan
2011-09-25 9:16 ` Marc Haber
2011-09-25 20:10 ` Nicolas de Pesloüan
2011-09-25 9:05 ` Marc Haber
2011-09-02 17:22 ` [PATCH 2/2] bridge: set flags in RTM_NEWNEIGH message correctly Stephen Hemminger
[not found] <20111004041444.793960297@vyatta.com>
2011-10-04 4:14 ` [PATCH 1/2] bridge: leave carrier on for empty bridge Stephen Hemminger
2011-10-06 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110902172247.396753508@vyatta.com \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.