All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Chen Gong <gong.chen@linux.intel.com>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pstore: update the policy of the UEFI-based backend
Date: Sat, 3 Sep 2011 13:36:11 +0100	[thread overview]
Message-ID: <20110903123611.GA28765@srcf.ucam.org> (raw)
In-Reply-To: <1315027817-5316-3-git-send-email-gong.chen@linux.intel.com>

I don't think this is reasonable. EFI variable space is a shared 
resource. We have no idea what the failure modes of entirely filling it 
would be. If we're going to store multiple records then at the very 
least we need to use QueryVariableInfo() to identify how much space 
there is left, and if it's a 2.1 or later system then we ideally need to 
store these as EFI_VARIABLE_HARDWARE_ERROR_RECORD rather than just plain 
runtime variables. The reason the current implementation doesn't do that 
is that there's still hardware floating around that implements EFI 1.10 
rather than UEFI 2.0

-- 
Matthew Garrett | mjg59@srcf.ucam.org

      reply	other threads:[~2011-09-03 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-03  5:30 pstore: enhancement for pstore write interface Chen Gong
2011-09-03  5:30 ` [PATCH 1/2] pstore: change the purpose of return value for pstore write operation Chen Gong
2011-09-03  5:30 ` [PATCH 2/2] pstore: update the policy of the UEFI-based backend Chen Gong
2011-09-03 12:36   ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110903123611.GA28765@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=gong.chen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.