All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"Steffen Daode Nurpmeso" <sdaoden@googlemail.com>,
	"Ingo Brückl" <ib@wupperonline.de>
Subject: Re: [PATCH 10/10] want_color: automatically fallback to color.ui
Date: Sun, 4 Sep 2011 08:53:12 -0400	[thread overview]
Message-ID: <20110904125312.GA21724@sigill.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.00.1109032212310.12564@debian>

On Sat, Sep 03, 2011 at 10:36:01PM -0400, Martin von Zweigbergk wrote:

> This patch makes format-patch output color escape codes to file when
> run with color.ui=always. Before the patch it did not do that. The
> documentation for color.ui says "Set it to always if you want all
> output not intended for machine consumption to use color". Is
> format-patch "intended for machine consumption" or not?

Sorry, this is a regression. The old behavior was that commands had to
copy color.ui's value manually into diff_use_color_default. With my
patch, the value is picked up automatically, and it is up to commands to
load or not load the specified config.

For diff plumbing versus porcelain, we have separate config code paths
(diff_basic versus diff_ui). I forgot that format-patch versus log has
the same situation, and needs the same split.

It's a long weekend here in the US, but I'll try to get a patch out on
Tuesday (and also check for any other similar regressions).

> I'm not sure why I had the parameter set to "always" instead of
> "true/auto" and maybe I should change it, but since this patch changes
> the behavior, I thought I should let you know (it was not mentioned in
> the commit message, so I'm not sure it was intentional).

Yeah, I don't think setting color.ui to "always" is all that useful. But
this behavior change was definitely not intentional. Thanks for
noticing.

-Peff

  reply	other threads:[~2011-09-04 12:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18  4:58 [PATCH 0/10] color and pager improvements Jeff King
2011-08-18  5:00 ` [PATCH 01/10] t7006: modernize calls to unset Jeff King
2011-08-18 21:05   ` Junio C Hamano
2011-08-18  5:01 ` [PATCH 02/10] test-lib: add helper functions for config Jeff King
2011-08-18 21:10   ` Junio C Hamano
2011-08-18  5:02 ` [PATCH 03/10] t7006: use test_config helpers Jeff King
2011-08-18  5:02 ` [PATCH 04/10] setup_pager: set GIT_PAGER_IN_USE Jeff King
2011-08-18  5:03 ` [PATCH 05/10] diff: refactor COLOR_DIFF from a flag into an int Jeff King
2011-08-18  5:03 ` [PATCH 06/10] git_config_colorbool: refactor stdout_is_tty handling Jeff King
2011-08-18  5:04 ` [PATCH 07/10] color: delay auto-color decision until point of use Jeff King
2011-08-18 21:59   ` Junio C Hamano
2011-08-18 22:28     ` Jeff King
2011-08-18  5:04 ` [PATCH 08/10] config: refactor get_colorbool function Jeff King
2011-08-18  5:05 ` [PATCH 09/10] diff: don't load color config in plumbing Jeff King
2011-08-18  5:05 ` [PATCH 10/10] want_color: automatically fallback to color.ui Jeff King
2011-09-04  2:36   ` Martin von Zweigbergk
2011-09-04 12:53     ` Jeff King [this message]
2011-09-05 11:31       ` Steffen Daode Nurpmeso
2011-08-18 21:58 ` [PATCH 0/10] color and pager improvements Jeff King
2011-08-18 21:59   ` [PATCH 11/10] support pager.* for aliases Jeff King
2011-08-18 22:54     ` Junio C Hamano
2011-08-19  3:37       ` Jeff King
2011-08-19  4:18         ` Junio C Hamano
2011-08-19  4:40           ` Jeff King
2011-08-19  5:23             ` Junio C Hamano
2011-08-19  5:43               ` Junio C Hamano
2011-08-19  8:30               ` Jeff King
2011-08-18 22:01   ` [PATCH 12/10] support pager.* for external commands Jeff King
2011-08-18 22:56     ` Junio C Hamano
2012-02-12  0:46     ` Ævar Arnfjörð Bjarmason
2012-02-14 19:13       ` Jeff King
2011-08-18 22:33   ` [PATCH 0/10] color and pager improvements Ingo Brückl
2011-08-18 22:46     ` Jeff King
2011-08-19  6:34       ` Ingo Brückl
2011-08-25 20:25         ` Jeff King
2011-08-18 21:59 ` Steffen Daode Nurpmeso
2011-08-18 22:02 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110904125312.GA21724@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ib@wupperonline.de \
    --cc=martin.von.zweigbergk@gmail.com \
    --cc=sdaoden@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.