From: Oleg Nesterov <oleg@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
eric.dumazet@gmail.com, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 4/4] posix-timers: turn it_signal into it_valid flag
Date: Sun, 4 Sep 2011 22:29:07 +0200 [thread overview]
Message-ID: <20110904202907.GA3404@redhat.com> (raw)
In-Reply-To: <20110904165658.GA23948@redhat.com>
On 09/04, Oleg Nesterov wrote:
>
> Although I
> feel this all can be simplified even more.
And perhaps we need some fixes?
I forgot everything I knew about ->it_requeue_pending logic, but it
seems to me that do_schedule_next_timer()->lock_timer() can find and
lock successfully the wrong timer. Another thread can do timer_delete()
and then re-create the timer with the same id.
Oleg.
next prev parent reply other threads:[~2011-09-04 20:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 23:39 [PATCH 1/4] posix-timers: move global timer id management to signal_struct v2 Andi Kleen
2011-08-29 23:39 ` [PATCH 2/4] posix-timers: limit the number of posix timers per process Andi Kleen
2011-08-30 21:44 ` Andrew Morton
2011-08-30 22:06 ` Andi Kleen
2011-08-30 22:22 ` Andrew Morton
2011-08-30 22:47 ` Andi Kleen
2011-08-30 23:02 ` Andrew Morton
2011-08-31 6:45 ` Jiri Slaby
2011-09-02 9:30 ` Thomas Gleixner
2011-08-29 23:39 ` [PATCH 3/4] posix-timers: Don't disable interrupts in idr_lock Andi Kleen
2011-08-29 23:39 ` [PATCH 4/4] posix-timers: turn it_signal into it_valid flag Andi Kleen
2011-09-02 10:06 ` Thomas Gleixner
2011-09-02 11:49 ` Eric Dumazet
2011-09-02 14:19 ` Thomas Gleixner
2011-09-04 16:56 ` Oleg Nesterov
2011-09-04 19:07 ` Andi Kleen
2011-09-04 20:29 ` Oleg Nesterov [this message]
2011-09-06 3:14 ` Andi Kleen
2011-09-06 14:51 ` Oleg Nesterov
2011-09-06 15:39 ` Eric Dumazet
2011-09-06 16:27 ` Oleg Nesterov
2011-09-06 18:47 ` Thomas Gleixner
2011-09-06 18:49 ` Oleg Nesterov
2011-09-06 19:16 ` Thomas Gleixner
2011-09-06 19:26 ` Oleg Nesterov
2011-09-06 19:45 ` Thomas Gleixner
2011-09-06 22:08 ` Oleg Nesterov
2011-09-06 22:34 ` Thomas Gleixner
2011-09-21 16:46 ` Thomas Gleixner
2011-09-21 17:56 ` Thomas Gleixner
2011-09-22 11:19 ` Thomas Gleixner
2011-09-06 19:30 ` Eric Dumazet
2011-09-06 20:10 ` Thomas Gleixner
2011-09-06 20:27 ` Eric Dumazet
2011-09-06 19:04 ` Eric Dumazet
2011-08-31 8:53 ` [PATCH 1/4] posix-timers: move global timer id management to signal_struct v2 Eric Dumazet
2011-08-31 16:57 ` Andi Kleen
2011-09-02 9:19 ` Thomas Gleixner
2011-09-02 10:05 ` Eric Dumazet
2011-09-19 21:46 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110904202907.GA3404@redhat.com \
--to=oleg@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.