From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vXJ-0008GZ-QY for qemu-devel@nongnu.org; Tue, 06 Sep 2011 09:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0vXI-00029t-Mj for qemu-devel@nongnu.org; Tue, 06 Sep 2011 09:17:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0vXI-00029p-EG for qemu-devel@nongnu.org; Tue, 06 Sep 2011 09:17:56 -0400 Date: Tue, 6 Sep 2011 10:17:52 -0300 From: Luiz Capitulino Message-ID: <20110906101752.59ae7588@doriath> In-Reply-To: <20110902112818.13bddde0@doriath> References: <1314900738-30164-1-git-send-email-lcapitulino@redhat.com> <1314900738-30164-4-git-send-email-lcapitulino@redhat.com> <4E5FCF61.4040404@siemens.com> <20110901153917.112c5428@doriath> <4E5FF20B.5030504@web.de> <20110902112818.13bddde0@doriath> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] RunState: Add additional states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "kwolf@redhat.com" , "amit.shah@redhat.com" , "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "armbru@redhat.com" On Fri, 2 Sep 2011 11:28:18 -0300 Luiz Capitulino wrote: > On Thu, 01 Sep 2011 22:58:51 +0200 > Jan Kiszka wrote: > > > On 2011-09-01 20:39, Luiz Capitulino wrote: > > > On Thu, 01 Sep 2011 20:30:57 +0200 > > > Jan Kiszka wrote: > > > > > >> On 2011-09-01 20:12, Luiz Capitulino wrote: > > >>> Currently, only vm_start() and vm_stop() change the VM state. > > >>> That's, the state is only changed when starting or stopping the VM. > > >>> > > >>> This commit adds the runstate_set() function, which makes it possible > > >>> to also do state transitions when the VM is stopped or running. > > >>> > > >>> Additional states are also added and the current state is stored. > > >>> > > >>> Signed-off-by: Luiz Capitulino > > >>> --- > > >>> cpus.c | 1 + > > >>> migration.c | 8 +++++++- > > >>> sysemu.h | 10 +++++++++- > > >>> vl.c | 20 ++++++++++++++++++++ > > >>> 4 files changed, 37 insertions(+), 2 deletions(-) > > >>> > > >> > > >> ... > > >> > > >>> diff --git a/vl.c b/vl.c > > >>> index f0b56a4..59f71fc 100644 > > >>> --- a/vl.c > > >>> +++ b/vl.c > > >>> @@ -321,6 +321,22 @@ static int default_driver_check(QemuOpts *opts, void *opaque) > > >>> } > > >>> > > >>> /***********************************************************/ > > >>> +/* QEMU state */ > > >>> + > > >>> +static RunState current_run_state = RSTATE_NO_STATE; > > >>> + > > >>> +bool runstate_check(RunState state) > > >>> +{ > > >>> + return current_run_state == state; > > >>> +} > > >>> + > > >>> +void runstate_set(RunState state) > > >>> +{ > > >>> + assert(state < RSTATE_MAX); > > >>> + current_run_state = state; > > >> > > >> I still think this should check for valid state transitions instead of > > >> blindly accepting what the caller passes in. > > > > > > I thought your comment where more like a future enhancement than > > > a request for change. > > > > I think we want this now to document at a central place which > > transitions are valid and which not. State machines without such checks > > break sooner or later, subtly. > > Ok, I'll do it. I did it in v4 (just sent). But it wasn't trivial to do and to test, so a careful review of that patch is very appreciated.