All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Mike Sterling <mike.sterling@microsoft.com>
Cc: haiyangz@microsoft.com, hjanssen@microsoft.com,
	kys@microsoft.com, gregkh@suse.de, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, virtualization@lists.osdl.org
Subject: Re: [PATCH 1/1] staging: hv: Add support for >2 TB LUN in storage driver.
Date: Tue, 6 Sep 2011 12:06:15 -0700	[thread overview]
Message-ID: <20110906190615.GA31897@kroah.com> (raw)
In-Reply-To: <1314915069-1796-1-git-send-email-mike.sterling@microsoft.com>

On Thu, Sep 01, 2011 at 03:11:09PM -0700, Mike Sterling wrote:
> If a LUN larger than 2 TB is attached to a Linux VM on Hyper-V, we currently 
> report a maximum size of 2 TB. This patch resolves the issue in hv_storvsc. 
> Thanks to Robert Scheck <robert.scheck@etes.de> for reporting the issue.
> 
> Reported-by: Robert Scheck <robert.scheck@etes.de>
> Signed-off-by: Mike Sterling <mike.sterling@microsoft.com>
> Signed-off-by: K.Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> ---
>  drivers/staging/hv/hyperv_storage.h |    1 +

This file is no longer in the latest kernel tree (linux-next or
staging-next).  What tree did you generate this patch against?  And
how come Haiyang and KY didn't catch such a basic mistake in their
review...

I'm guessing that this patch was not even tested :(

Please fix this and resend.

greg k-h

  parent reply	other threads:[~2011-09-06 19:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-01 22:11 [PATCH 1/1] staging: hv: Add support for >2 TB LUN in storage driver Mike Sterling
2011-09-01 22:22 ` Greg KH
2011-09-06 15:33   ` Mike Sterling
2011-09-06 19:06 ` Greg KH [this message]
2011-09-06 19:14   ` Mike Sterling
2011-09-06 19:14     ` Mike Sterling
  -- strict thread matches above, loose matches on Subject: below --
2011-09-06 23:10 [PATCH 1/1] Staging: " Mike Sterling
2011-09-01 21:11 [PATCH 1/1] staging: " Mike Sterling
2011-09-01 20:59 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110906190615.GA31897@kroah.com \
    --to=greg@kroah.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@suse.de \
    --cc=haiyangz@microsoft.com \
    --cc=hjanssen@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.sterling@microsoft.com \
    --cc=virtualization@lists.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.