From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756150Ab1IGSPn (ORCPT ); Wed, 7 Sep 2011 14:15:43 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:38436 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896Ab1IGSPl (ORCPT ); Wed, 7 Sep 2011 14:15:41 -0400 Date: Wed, 07 Sep 2011 14:14:24 -0400 (EDT) Message-Id: <20110907.141424.1469075127690660949.davem@davemloft.net> To: tglx@linutronix.de Cc: yong.zhang0@gmail.com, linux-kernel@vger.kernel.org, mingo@elte.hu, joe@perches.com, sparclinux@vger.kernel.org Subject: Re: [PATCH 20/62] sparc: irq: Remove IRQF_DISABLED From: David Miller In-Reply-To: References: <20110907.135110.2069876782156753239.davem@davemloft.net> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Wed, 07 Sep 2011 11:14:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner Date: Wed, 7 Sep 2011 19:57:21 +0200 (CEST) > On Wed, 7 Sep 2011, David Miller wrote: >> From: Thomas Gleixner >> Date: Wed, 7 Sep 2011 19:33:52 +0200 (CEST) >> >> We had big problems when openning thousands of virtual network >> devices, each with their own unique IRQ, and pointed all at the same >> cpu, and we'd get IRQ stack overflows. >> >> See commit c58543c869606532c2382f027d6466f4672ea756 >> >> So this change to make IRQF_DISABLED a nop has reintroduced this bug. > > See commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922 > > We run ALL interrupt handlers with interrupts disabled for that reason > and we even check and yell when an interrupt handler returns with > interrupts enabled. That's why IRQF_DISABLED became meaningless. Awesome. Can I politely ask that a reference to that commit and something like your paragraph here explaining things is added to these IRQF_DISABLED removal patches? Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Wed, 07 Sep 2011 18:14:24 +0000 Subject: Re: [PATCH 20/62] sparc: irq: Remove IRQF_DISABLED Message-Id: <20110907.141424.1469075127690660949.davem@davemloft.net> List-Id: References: <20110907.135110.2069876782156753239.davem@davemloft.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: tglx@linutronix.de Cc: yong.zhang0@gmail.com, linux-kernel@vger.kernel.org, mingo@elte.hu, joe@perches.com, sparclinux@vger.kernel.org From: Thomas Gleixner Date: Wed, 7 Sep 2011 19:57:21 +0200 (CEST) > On Wed, 7 Sep 2011, David Miller wrote: >> From: Thomas Gleixner >> Date: Wed, 7 Sep 2011 19:33:52 +0200 (CEST) >> >> We had big problems when openning thousands of virtual network >> devices, each with their own unique IRQ, and pointed all at the same >> cpu, and we'd get IRQ stack overflows. >> >> See commit c58543c869606532c2382f027d6466f4672ea756 >> >> So this change to make IRQF_DISABLED a nop has reintroduced this bug. > > See commit e58aa3d2d0cc01ad8d6f7f640a0670433f794922 > > We run ALL interrupt handlers with interrupts disabled for that reason > and we even check and yell when an interrupt handler returns with > interrupts enabled. That's why IRQF_DISABLED became meaningless. Awesome. Can I politely ask that a reference to that commit and something like your paragraph here explaining things is added to these IRQF_DISABLED removal patches? Thanks!